Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7d67b02 changes or corrupts project format without warning (from 313ec55) #24772

Closed
qgib opened this issue Jul 15, 2017 · 13 comments
Closed

7d67b02 changes or corrupts project format without warning (from 313ec55) #24772

qgib opened this issue Jul 15, 2017 · 13 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Project Regression Something which used to work, but doesn't anymore

Comments

@qgib
Copy link
Contributor

qgib commented Jul 15, 2017

Author Name: Patrick Dunford (@enzedrailmaps)
Original Redmine Issue: 16873
Affected QGIS version: master
Redmine category:project_loading/saving


If I open a project in 7d67b02 then save it then try to reopen it in 313ec55 some data can't be read.
Examples include the project CRS, and layer labels.

There are no warnings on opening the project in 7d67b02 that the project file format has changed, which would ordinarily be the case.

@qgib
Copy link
Contributor Author

qgib commented Jul 15, 2017

Author Name: Patrick Dunford (@enzedrailmaps)


It looks like in 7d67b02 it has trouble recognising the CRS because it's displaying in project properties "No projection or unknown/non-earth projection"

@qgib
Copy link
Contributor Author

qgib commented Jul 15, 2017

Author Name: Giovanni Manghi (@gioman)


  • crashes_corrupts_data was changed from 1 to 0

@qgib
Copy link
Contributor Author

qgib commented Jul 16, 2017

Author Name: Patrick Dunford (@enzedrailmaps)


This has been confirmed as an issue in Windows 7 x64 with build c1d339c

I disagree that you have changed the status of "Corrupts data" to No because there is significant data not being displayed on the map, indicating the project file is probably corrupted.

@qgib
Copy link
Contributor Author

qgib commented Jul 16, 2017

Author Name: Giovanni Manghi (@gioman)


Patrick Dunford wrote:

This has been confirmed as an issue in Windows 7 x64 with build c1d339c

indicating the project file is probably corrupted.

have you checked? project files are xml that you can compare easily.

@qgib
Copy link
Contributor Author

qgib commented Jul 16, 2017

Author Name: Giovanni Manghi (@gioman)


Patrick Dunford wrote:

This has been confirmed as an issue in Windows 7 x64 with build c1d339c

I disagree that you have changed the status of "Corrupts data" to No because there is significant data not being displayed on the map, indicating the project file is probably corrupted.

I also think that with the amount of work and changes being done on qgis master this should be probably be spotted and fixed soon.


  • priority_id was changed from Normal to High
  • regression was changed from 0 to 1

@qgib
Copy link
Contributor Author

qgib commented Jul 16, 2017

Author Name: Patrick Dunford (@enzedrailmaps)


Sample data:
https://drive.google.com/open?id=0ByH1cL0SIi1vWkQ0cFR4NVBGc3c

Confirmed as an issue with Linux build 7d67b02 and later, Windows build c1d339c

Download the folder "Qgis Sample"
Start Qgis and click to open a project
Open the QGis Sample folder
Open the GD folder
Open the RM folder
Open the Project folder
Open the OS folder
Open the project file "OtagoSouthland299c.qgs"
There should be a message about 97 missing layers, this can be ignored (click OK)
As the project opens you will see "Exception" Could not create transform to calculate true north
The reason for this error is the project CRS has not been recognised. Click on Project Properties then you can see "No projection (or unknown / non earth projection)" is checked. (The project was created with the EPSG:3857 projection)

Familiarise yourself with the range of layers being displayed in the map.
Save the project under a new name.
Close Qgis (or click the New button to close the current project)
Start Qgis (or re open the project)
Notice how many layers are not now displayed. In particular:
All of the "Global Water" layers
All of the "Land" layers
All of the "Terrain" layers.
All layer labels have disappeared.

@qgib
Copy link
Contributor Author

qgib commented Jul 20, 2017

Author Name: Jürgen Fischer (@jef-n)


  • description was changed from If I open a project in 7d67b02 then save it then try to reopen it in 313ec55 some data can't be read.
    Examples include the project CRS, and layer labels.

There are no warnings on opening the project in 7d67b02 that the project file format has changed, which would ordinarily be the case. to If I open a project in commit:7d67b02 then save it then try to reopen it in 313ec55 some data can't be read.
Examples include the project CRS, and layer labels.

There are no warnings on opening the project in commit:7d67b02 that the project file format has changed, which would ordinarily be the case.

@qgib
Copy link
Contributor Author

qgib commented Sep 7, 2017

Author Name: Patrick Dunford (@enzedrailmaps)


And this is a still a problem in the latest master 655f121

@qgib
Copy link
Contributor Author

qgib commented Sep 8, 2017

Author Name: Nyall Dawson (@nyalldawson)


Are you loading a project from an earlier 3.0 build, or a stable 2.x build?


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Sep 8, 2017

Author Name: Patrick Dunford (@enzedrailmaps)


It's several projects I have been working with in 2.99 through various builds throughout the past year or so. They have been updated numerous times with new masters changing formats. However the masters I use most frequently (stable enough to be used all the time for production projects) are 313ec55 on Xubuntu 16.04/17.04 and 1182816 on Windows 7.

@qgib
Copy link
Contributor Author

qgib commented Sep 9, 2017

Author Name: Nyall Dawson (@nyalldawson)


In that case there's no issue here - we don't gaurantee project stability during a development release (since it adds extra code we have to stay around forever more). If this was a 2.x project, then it's a different story.


  • status_id was changed from Feedback to Closed
  • resolution was changed from to invalid

@qgib qgib closed this as completed Sep 9, 2017
@qgib
Copy link
Contributor Author

qgib commented Sep 9, 2017

Author Name: Patrick Dunford (@enzedrailmaps)


Nyall Dawson wrote:

In that case there's no issue here - we don't gaurantee project stability during a development release (since it adds extra code we have to stay around forever more). If this was a 2.x project, then it's a different story.

The expected behaviour in all other versions of the software is a warning message telling you that the project format has changed.

@qgib
Copy link
Contributor Author

qgib commented Sep 9, 2017

Author Name: Patrick Dunford (@enzedrailmaps)


Two questions:

  1. Either the software intentionally upgrades the project file format without issuing a warning, or
  2. The software contains a bug that causes the project file format to become corrupted.

I don't think this response has resolved either of those questions.

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Project Regression Something which used to work, but doesn't anymore labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Project Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant