Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation dialog for save / rollback / cancel all layers changes no longer appears in master #25387

Closed
qgib opened this issue Nov 18, 2017 · 3 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality High Priority Regression Something which used to work, but doesn't anymore

Comments

@qgib
Copy link
Contributor

qgib commented Nov 18, 2017

Author Name: Patrick Dunford (@enzedrailmaps)
Original Redmine Issue: 17490
Affected QGIS version: master
Redmine category:digitising


In 2.18 and earlier editions of Qgis when one of the save/rollback/cancel options is clicked there is a confirmation dialog presented to confirm the action. This is important as clicking the wrong option can cause a loss of data.

This confirmation dialog no longer exists in master. Whilst it is more convenient in some cases to avoid having to click a button in a dialog box, this has to be balanced against the potential for data loss if the wrong button is clicked, especially as there is no ability to undo an operation.

@qgib
Copy link
Contributor Author

qgib commented Nov 21, 2017

Author Name: Giovanni Manghi (@gioman)


I see this as a bug/regression, but maybe a developer wants to chime in here as it could be a change made on purpose.


  • regression was changed from 0 to 1
  • operating_system was changed from Debian 9.1 to
  • priority_id was changed from Normal to High

@qgib
Copy link
Contributor Author

qgib commented Feb 6, 2018

Author Name: Nyall Dawson (@nyalldawson)


Applied in changeset 15e04bc.


  • done_ratio was changed from 0 to 100
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Feb 6, 2018
@qgib
Copy link
Contributor Author

qgib commented Feb 22, 2018

Author Name: Giovanni Manghi (@gioman)


  • resolution was changed from to fixed/implemented

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Digitizing Related to feature digitizing map tools or functionality Regression Something which used to work, but doesn't anymore labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality High Priority Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant