[layer properties] the Edit button should not open a "Add Vector Join" dialog

[qgib]

Author Name: Harrissou Santanna (@DelazJ)
Original Redmine Issue: 17554
Affected QGIS version: 3.5(master)
Redmine category:unknown

---

In Vector layer properties > Join tab, clicking the Edit button should not open a "Add Vector Join" dialog. It's confusing.
Also note that in the opened dialog, one of the filled information is not retrieved (in my case, the Join field). I think all the information filled should be retrieved and up to the user to replace the one(s) no longer good.

[qgib]

Author Name: Jürgen Fischer (@jef-n)

---

Please test with QGIS 3.4 - QGIS 2.18 reached it's end of life.

---

• status_id was changed from Open to Feedback

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

I can't see the field issue reported above so this is a dialog renaming issue that I try to address in #8926

---

• pull_request_patch_supplied was changed from 0 to 1
• version was changed from 2.18.14 to 3.5(master)
• status_id was changed from Feedback to Open

[qgib]

Author Name: Harrissou Santanna (@DelazJ)

---

Applied in changeset d70191d.

---

• done_ratio was changed from 0 to 100
• status_id was changed from Open to Closed