Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGIS master: is_layer_visible () does not update automatically #25514

Closed
qgib opened this issue Dec 4, 2017 · 13 comments
Closed

QGIS master: is_layer_visible () does not update automatically #25514

qgib opened this issue Dec 4, 2017 · 13 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Expressions Related to the QGIS expression engine or specific expression functions

Comments

@qgib
Copy link
Contributor

qgib commented Dec 4, 2017

Author Name: salvatore fiandaca (salvatore fiandaca)
Original Redmine Issue: 17617
Affected QGIS version: master
Redmine category:expressions


I used the function is_layer_visible () to change the appearance of the labels, but you need to do a manual refresc, it does not update automatically.


@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Giovanni Manghi (@gioman)


Is this a regression (works as expected in 2.18.* or earlier)?


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Giovanni Manghi (@gioman)


  • subject was changed from QGIS master d0e927a - is_layer_visible () does not update automatically to QGIS master: is_layer_visible () does not update automatically

@qgib
Copy link
Contributor Author

qgib commented Dec 4, 2017

Author Name: Giovanni Manghi (@gioman)


  • category_id was changed from Symbology to Labelling

@qgib
Copy link
Contributor Author

qgib commented Feb 22, 2018

Author Name: Giovanni Manghi (@gioman)


Feedback needed here. Is a regression in QGIS 3 (did it worked as expected in QGIS 2)?

@qgib
Copy link
Contributor Author

qgib commented Feb 22, 2018

Author Name: salvatore fiandaca (salvatore fiandaca)


In QGIS 2, the is_layer_visible function does not exist; so it's not a regression.

@qgib
Copy link
Contributor Author

qgib commented Aug 16, 2018

Author Name: Giovanni Manghi (@gioman)


Still true on the latest master?

@qgib
Copy link
Contributor Author

qgib commented Aug 16, 2018

Author Name: salvatore fiandaca (salvatore fiandaca)


Giovanni Manghi wrote:

Still true on the latest master?

yes, it is still true in the last master - gnu / linux mint 19
as soon as I can I try in win 10

@qgib
Copy link
Contributor Author

qgib commented Aug 20, 2018

Author Name: Giovanni Manghi (@gioman)


  • category_id was changed from Labelling to Expressions
  • operating_system was changed from win 10 64b to
  • status_id was changed from Feedback to Open

@qgib
Copy link
Contributor Author

qgib commented Aug 20, 2018

Author Name: Nyall Dawson (@nyalldawson)


I think this is a "wont fix". Expressions in QGIS can be very complex and adding a method to determine the dependencies of an expression would be almost impossible. For instance, there's also expressions which fetch features from other layers, expressions which calculate aggregates from other layers, expressions which use related features, etc. We'd also need to consider all these cases and force a refresh whenever any of the dependencies change. But then there's also expressions which rely on variables too. Then there's also the need to consider everywhere expressions can be used which may need refreshing... e.g. canvas renders, layout items, virtual fields, data defined properties, etc.

I think given the extreme complexity of solving this and the easy workaround (refresh the canvas manually) it should be tagged as "wontfix"

@qgib
Copy link
Contributor Author

qgib commented Aug 21, 2018

Author Name: salvatore fiandaca (salvatore fiandaca)


Nyall Dawson wrote:

I think this is a "wont fix". Expressions in QGIS can be very complex and adding a method to determine the dependencies of an expression would be almost impossible. For instance, there's also expressions which fetch features from other layers, expressions which calculate aggregates from other layers, expressions which use related features, etc. We'd also need to consider all these cases and force a refresh whenever any of the dependencies change. But then there's also expressions which rely on variables too. Then there's also the need to consider everywhere expressions can be used which may need refreshing... e.g. canvas renders, layout items, virtual fields, data defined properties, etc.

I think given the extreme complexity of solving this and the easy workaround (refresh the canvas manually) it should be tagged as "wontfix"

Thanks for the reply

@qgib
Copy link
Contributor Author

qgib commented Aug 21, 2018

Author Name: Giovanni Manghi (@gioman)


So... closing?

@qgib
Copy link
Contributor Author

qgib commented Aug 21, 2018

Author Name: salvatore fiandaca (salvatore fiandaca)


Giovanni Manghi wrote:

So... closing?

for me, Nyall explanation is ok

@qgib
Copy link
Contributor Author

qgib commented Aug 21, 2018

Author Name: Giovanni Manghi (@gioman)


  • resolution was changed from to wontfix
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Aug 21, 2018
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Expressions Related to the QGIS expression engine or specific expression functions labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Expressions Related to the QGIS expression engine or specific expression functions
Projects
None yet
Development

No branches or pull requests

1 participant