Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub PR template has broken link #25537

Closed
qgib opened this issue Dec 5, 2017 · 4 comments
Closed

GitHub PR template has broken link #25537

qgib opened this issue Dec 5, 2017 · 4 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Documentation Changes to Documentation, README, INSTALL, etc Easy fix High Priority

Comments

@qgib
Copy link
Contributor

qgib commented Dec 5, 2017

Author Name: Sandro Santilli (@strk)
Original Redmine Issue: 17640
Affected QGIS version: master
Redmine category:documentation_and_help
Assignee: Richard Duivenvoorde


The PR template recommends you to read
https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html
But that URL is a 404

I've no idea which "Category" to assign to this ticket... (maybe it should not even be on this tracker..)

@qgib
Copy link
Contributor Author

qgib commented Dec 6, 2017

Author Name: Harrissou Santanna (@DelazJ)


Yes, it's an issue related to recent move from http to https. https://docs.qgis.org leads to qgis.org instead of documentation site.


  • assigned_to_id was changed from Yves Jacolin to Richard Duivenvoorde

@qgib
Copy link
Contributor Author

qgib commented Dec 6, 2017

Author Name: Yves Jacolin (@yjacolin)


Anyways, this link is for developper so if we want to doc contributors read something, it should be http://docs.qgis.org/testing/en/docs/documentation_guidelines/ instead.

@qgib
Copy link
Contributor Author

qgib commented Dec 6, 2017

Author Name: Harrissou Santanna (@DelazJ)


Yves Jacolin wrote:

Anyways, this link is for developper so if we want to doc contributors read something, it should be http://docs.qgis.org/testing/en/docs/documentation_guidelines/ instead.

It's the right link; the target are devs and not doc contributors. The context is https://github.com/qgis/QGIS/blob/master/.github/PULL_REQUEST_TEMPLATE.md

@qgib
Copy link
Contributor Author

qgib commented Dec 6, 2017

Author Name: Richard Duivenvoorde (@rduivenvoorde)


Hi, sorry. I wasn't sure if we would make documentation website 100% https.
So I did not create a letsencrypt certificate for it yet...

Now I have:

Both:
https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html
and
http://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html
work now: pointing to https site (letsencrypt certificates)

docs.qgis.org is indeed pointing to the 'index' page of documentation. I think that is ok for now.


  • resolution was changed from to fixed/implemented
  • status_id was changed from Open to Closed
  • easy_fix was changed from 0 to 1
  • pull_request_patch_supplied was changed from 0 to 1

@qgib qgib closed this as completed Dec 6, 2017
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Documentation Changes to Documentation, README, INSTALL, etc Easy fix labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Documentation Changes to Documentation, README, INSTALL, etc Easy fix High Priority
Projects
None yet
Development

No branches or pull requests

1 participant