Honour Qt ordering of buttons in Source Select dialogues

[qgib]

Author Name: Ross McDonald (@mixedbredie)
Original Redmine Issue: 17728
Affected QGIS version: master
Redmine category:data_source_manager
Assignee: Alessandro Pasotti

---

The buttons in the source select dialogues of the Manage Layers toolbar in QGIS master are currently arranged at bottom left of the box as [Close, Add]. In my Windows 7 environment I would expect the buttons to be arranged [Add, Close] as they are in QGIS 2.18.x.

In addition, some extremely minor adjustments are needed on the Virtual Layer tab (the buttons move a few pixels down and right, the Add button is activated, Help button), the WFS/ArcGIS Map Server/ArcGIS Feature Server/GeoNode tabs (the buttons move a few pixels down and right).

I asked the question on the mailing list (http://lists.osgeo.org/pipermail/qgis-user/2017-December/041232.html) and Alessandro replied saying the buttons could be moved from the base class to the UI file to improve placement and order.

[qgib]

Author Name: Anónimo (Anónimo)

---

Applied in changeset 8fb147f.

---

• done_ratio was changed from 0 to 100
• status_id was changed from Open to Closed

[qgib]

Author Name: Alessandro Pasotti (@elpaso)

---

Note that I've only moved the buttons to the main button box using the methods of the button box, this means that the buttons will take the order and the look and feel specified by the platform/O.S. used.

I didn't address any other issue and I don't think that it is a good idea to change the "standard" order of the buttons within respect with that specified by the O.S. UX/UI guidelines.

[qgib]

Author Name: Giovanni Manghi (@gioman)

---

• resolution was changed from to fixed/implemented