Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Distance Buffer makes 0 (zero) distance invalid #26429

Closed
qgib opened this issue Mar 26, 2018 · 2 comments
Closed

Fixed Distance Buffer makes 0 (zero) distance invalid #26429

qgib opened this issue Mar 26, 2018 · 2 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore

Comments

@qgib
Copy link
Contributor

qgib commented Mar 26, 2018

Author Name: Steve Lowman (Steve Lowman)
Original Redmine Issue: 18541
Affected QGIS version: 2.18.17
Redmine category:processing/qgis
Assignee: Victor Olaya


I do a fixed-distance buffer on a polygon layer with the distance parameter as 0.0 (zero). This fails because 0 (zero) is classed as an invalid distance.

In older QGIS versions, and in the OGR 'Buffer Vectors' algorithm, this works well, and I have often used it as a method to remove most types of invalid geometry. Therefore, I think this is a regression.


@qgib
Copy link
Contributor Author

qgib commented Mar 26, 2018

Author Name: Nyall Dawson (@nyalldawson)


This is not a qgis bug, it's a bug in SAGA.

You could try the other buffer algorithms such as the native QGIS "fixed distance buffer" algorithm instead.


  • resolution was changed from to up/downstream
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Mar 26, 2018
@qgib
Copy link
Contributor Author

qgib commented Mar 26, 2018

Author Name: Steve Lowman (Steve Lowman)


Thank you, yes, I was testing the tool in the wrong list. I was trying to test whether the native tool can work on features with invalid geometry. It cannot (see #25189), so I think it is best to use the OGR buffer tool for fixed distance, and perhaps the Saga one for variable distance buffers.

I wonder whether I should make a feature request to replace the native buffer tools in the Vector menu for QGIS 2, due to the outcome of #25189?

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant