Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGIS 3: vertex editor highlights features in non-visible layers #26516

Closed
qgib opened this issue Apr 4, 2018 · 11 comments
Closed

QGIS 3: vertex editor highlights features in non-visible layers #26516

qgib opened this issue Apr 4, 2018 · 11 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality

Comments

@qgib
Copy link
Contributor

qgib commented Apr 4, 2018

Author Name: Carolyn Krause (Carolyn Krause)
Original Redmine Issue: 18628
Affected QGIS version: 3.0.0
Redmine category:digitising


Using vertex editor tool to hover over features, the nodes of those features are highlighted in red. This is fine. But features are highlighted even from layers that are disabled in layers panel. It seems like features that are disabled in layers panel should not be highlighted.



Related issue(s): #26323 (relates)
Redmine related issue(s): 18434


@qgib
Copy link
Contributor Author

qgib commented May 3, 2018

Author Name: Regis Haubourg (@haubourg)


Should be fixed by #6657
Please reopen if necessary


  • resolution was changed from to fixed/implemented
  • status_id was changed from Open to Closed

@qgib
Copy link
Contributor Author

qgib commented Jun 3, 2018

Author Name: Jürgen Fischer (@jef-n)


@qgib
Copy link
Contributor Author

qgib commented Jun 14, 2018

Author Name: Carolyn Krause (Carolyn Krause)


This issue is still occurring in QGIS 3.0.3.


  • 12836 was configured as Capture14.PNG
  • status_id was changed from Closed to Reopened

@qgib
Copy link
Contributor Author

qgib commented Jun 25, 2018

Author Name: Tobias Heinzmann (Tobias Heinzmann)


I have the same problem. I'm using QGIS version 3.2.0. It shows mainly layers that are disabled when I want to edit a layer. Is there a way to disable this behavior? It makes no sense to show objects that are not in the editing mode.

@qgib
Copy link
Contributor Author

qgib commented Oct 16, 2018

Author Name: Chris Buckmaster (Chris Buckmaster)


I had the same problem and noticed that 'Enable snapping by default' was ticked on under the 'Digitizing' options. Unticking this has removed the issue.

A colleague didn't have this turned on after both completing fresh installs of version 3.2.3 so I am not sure why there are differences?

@qgib
Copy link
Contributor Author

qgib commented Oct 16, 2018

Author Name: Giovanni Manghi (@gioman)


Carolyn Krause wrote:

This issue is still occurring in QGIS 3.0.3.

I tested on master, and despite having snapping enabled for all layers it does not work for invibile layers (as soon you enable one of them it works). Please test on 3.2/3.3, thanks!


  • status_id was changed from Reopened to Feedback
  • resolution was changed from fixed/implemented to

@qgib
Copy link
Contributor Author

qgib commented Oct 22, 2018

Author Name: Carolyn Krause (Carolyn Krause)


Tested in 3.2.

I turned off 'enable snapping by default' (in digitizing options). Now the vertex editor only acts on layers which are turned on and in editing mode. So now it's behaving the way I expect. It's still slightly unexpected that the vertex editor isn't limited to the selected layer, but that's not really a bug.

Just to test, I turned the 'enable snapping by default' option back on. With this option on, the vertex editor highlights all layers, regardless of whether they're in editing mode or currently visible on the canvas.

So the bug isn't 100% fixed, but turning off the 'enable snapping by default' option is a functional workaround. Thank you!


This might be completely unrelated, but every time I changed the 'enable snapping by default' setting, I got an error message (below). When I click okay on the error message, QGIS doesn't crash, and nothing bad happens. I get the same error message if I open the options window and click 'ok' without changing any settings.

An error has occurred while executing Python code:

RuntimeError: wrapped C/C++ object of type ClusterPointsAlgorithm has been deleted
Traceback (most recent call last):
File "C:/Users/CRRGIS/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\ClusterPoints\ClusterPoints.py", line 92, in loadAlgorithms
self.addAlgorithm( alg )
RuntimeError: wrapped C/C++ object of type ClusterPointsAlgorithm has been deleted

Python version: 3.6.0 (v3.6.0:41df79263a11, Dec 23 2016, 07:18:10) [MSC v.1900 32 bit (Intel)]
QGIS version: 3.2.3-Bonn Bonn, 9b17680

Python Path:
C:/Users/CRRGIS/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins\ClusterPoints
C:/PROGRA1/QGIS31.2/apps/qgis/./python
C:/Users/CRRGIS/AppData/Roaming/QGIS/QGIS3\profiles\default/python
C:/Users/CRRGIS/AppData/Roaming/QGIS/QGIS3\profiles\default/python/plugins
C:/PROGRA1/QGIS31.2/apps/qgis/./python/plugins
C:\Program Files\QGIS 3.2\bin\python36.zip
C:\PROGRA1\QGIS31.2\apps\Python36\DLLs
C:\PROGRA1\QGIS31.2\apps\Python36\lib
C:\Program Files\QGIS 3.2\bin
C:\PROGRA1\QGIS31.2\apps\Python36
C:\PROGRA1\QGIS31.2\apps\Python36\lib\site-packages
C:\PROGRA1\QGIS31.2\apps\Python36\lib\site-packages\win32
C:\PROGRA1\QGIS31.2\apps\Python36\lib\site-packages\win32\lib
C:\PROGRA1\QGIS31.2\apps\Python36\lib\site-packages\Pythonwin
C:/Users/CRRGIS/AppData/Roaming/QGIS/QGIS3\profiles\default/python
C:\Users\CRRGIS\AppData\Roaming\QGIS\QGIS3\profiles\default\python\plugins\DigitizingTools\tools
C:\Users\CRRGIS\AppData\Roaming\QGIS\QGIS3\profiles\default\python\plugins\mmqgis/forms
C:/Users/CRRGIS/Documents/GIS DataBase

@qgib
Copy link
Contributor Author

qgib commented Nov 8, 2018

Author Name: Carolyn Krause (Carolyn Krause)


This issue is resolved in QGIS 3.4. Non-visible layers are no longer highlighted by the Vertex Editor. And I love the new option to choose between "Vertex Tool (All Layers)" and "Vertex Tool (Current Layer)". Thank you!

@qgib
Copy link
Contributor Author

qgib commented Nov 9, 2018

Author Name: Nyall Dawson (@nyalldawson)


  • status_id was changed from Feedback to Closed
  • resolution was changed from to fixed/implemented

@qgib qgib closed this as completed Nov 9, 2018
@qgib
Copy link
Contributor Author

qgib commented Feb 2, 2019

Author Name: Cory Albrecht (@CoryAlbrecht)


Carolyn Krause wrote:

This issue is resolved in QGIS 3.4. Non-visible layers are no longer highlighted by the Vertex Editor. And I love the new option to choose between "Vertex Tool (All Layers)" and "Vertex Tool (Current Layer)". Thank you!

I am still seeing it in 3.4.4 on Ubuntu GNOME.

@qgib
Copy link
Contributor Author

qgib commented Feb 7, 2019

Author Name: Giovanni Manghi (@gioman)


Cory Albrecht wrote:

Carolyn Krause wrote:

This issue is resolved in QGIS 3.4. Non-visible layers are no longer highlighted by the Vertex Editor. And I love the new option to choose between "Vertex Tool (All Layers)" and "Vertex Tool (Current Layer)". Thank you!

I am still seeing it in 3.4.4 on Ubuntu GNOME.

there have many fixed in the digitizing tools in the last days, please give qgis master a try.

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Digitizing Related to feature digitizing map tools or functionality
Projects
None yet
Development

No branches or pull requests

1 participant