Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard Empty Fields: behaviour, default status, name #26901

Closed
qgib opened this issue May 31, 2018 · 5 comments
Closed

Discard Empty Fields: behaviour, default status, name #26901

qgib opened this issue May 31, 2018 · 5 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers Feedback Waiting on the submitter for answers stale Uh oh! Seems this work is abandoned, and the PR is about to close.

Comments

@qgib
Copy link
Contributor

qgib commented May 31, 2018

Author Name: Simon Dedman (@SimonDedman)
Original Redmine Issue: 19071
Affected QGIS version: 3.0.3
Redmine category:data_provider/delimited_text_


Imagine a csv with columns:
lat, long, 2016_data, 2017_data, 2018_data, Total
Where a selection of the 2016:18 cells are blank.
If one imports this as a layer and doesn't notice the 'discard empty fields' option is on (by default, 2.18.20 & 3.0.3), Qgis will not discard empty FIELDS, as defined elsewhere (e.g. layer properties) as being the columns of data, but will discard empty CELLS.... and then slide all cells left to fill the blanks, such that e.g.:

lat, long, 2016_data, 2017_data, 2018_data, Total
la1 lo1 2 =blank= 3 5

would become
lat, long, 2016_data, 2017_data, 2018_data, Total
la1 lo1 2 3 5 =blank=

and therefore plotting Total would show you that there are no data when you can see from your original csv that there certainly are.
This may be the correct implementation for fields for other file types but is very much counterintuitive and bad for csvs. Please could:

  1. 'discard empty fields' be turned off by default, either for csvs or all
  2. 'discard empty fields' be renamed to e.g. 'remove blank cells', ideally with explanatory tooltip
  3. This behaviour be corrected so blank fields i.e. columns of data are removed but not cells, or rather not with the post-removal rearrangement of other fields' data.

Thanks.

@qgib
Copy link
Contributor Author

qgib commented Dec 24, 2018

Author Name: Alexander Bruy (@alexbruy)


  • operating_system was changed from Win10 to
  • category_id was changed from Processing/Core to Data Provider/Delimited Text

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers labels May 25, 2019
@alexbruy
Copy link
Contributor

@ccrook what is your opinion on this?

@Pedro-Murteira
Copy link

Tested on versions 3.22.4 and 3.24.0. "Discard Empty Fields" seems to be turned off by default. Did you come across this issue in more recent versions of QGIS? @SimonDedman

@gioman gioman added the Feedback Waiting on the submitter for answers label Mar 11, 2022
@github-actions
Copy link

The QGIS project highly values your report and would love to see it addressed. However, this issue has been left in feedback mode for the last 14 days and is being automatically marked as "stale".
If you would like to continue with this issue, please provide any missing information or answer any open questions. If you could resolve the issue yourself meanwhile, please leave a note for future readers with the same problem and close the issue.
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this issue.
If there is no further activity on this issue, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 26, 2022
@github-actions
Copy link

While we hate to see this happen, this issue has been automatically closed because it has not had any activity in the last 42 days despite being marked as feedback. If this issue should be reconsidered, please follow the guidelines in the previous comment and reopen this issue.
Or, if you have any further questions, there are also further support channels that can help you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Data Provider Related to specific vector, raster or mesh data providers Feedback Waiting on the submitter for answers stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

No branches or pull requests

4 participants