Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voronoi.py swallows exceptions #27623

Closed
qgib opened this issue Sep 8, 2018 · 3 comments
Closed

voronoi.py swallows exceptions #27623

qgib opened this issue Sep 8, 2018 · 3 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Easy fix Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@qgib
Copy link
Contributor

qgib commented Sep 8, 2018

Author Name: john kastner (john kastner)
Original Redmine Issue: 19798
Affected QGIS version: 3.3(master)
Redmine category:processing/core


On line 362 of voronoi.py, there is the line except Exception as err: which is used to swallow all exceptions thrown in the method voronoi. This is generally a bad idea and and is making my life a lot harder while debugging an issue I'm having with the Voronoi Polygons geometry tool.

https://github.com/qgis/QGIS/blob/master/python/plugins/processing/algs/qgis/voronoi.py#L362

My suggested fix is to remove this try/except block so that exceptions can propagate up the stack freely. It may be better to instead modify the expect statement to catch only some relevant exceptions that actually should be ignored.

@qgib
Copy link
Contributor Author

qgib commented Sep 8, 2018

Author Name: john kastner (john kastner)


pull request: #7832

@qgib
Copy link
Contributor Author

qgib commented Sep 8, 2018

Author Name: john kastner (john kastner)


Applied in changeset 0cc9501.


  • done_ratio was changed from 0 to 100
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Sep 8, 2018
@qgib
Copy link
Contributor Author

qgib commented Sep 8, 2018

Author Name: Giovanni Manghi (@gioman)


  • resolution was changed from to fixed/implemented

@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms Easy fix labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Easy fix Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

No branches or pull requests

1 participant