voronoi.py swallows exceptions #27623
Labels
Bug
Either a bug report, or a bug fix. Let's hope for the latter!
Easy fix
Processing
Relating to QGIS Processing framework or individual Processing algorithms
Author Name: john kastner (john kastner)
Original Redmine Issue: 19798
Affected QGIS version: 3.3(master)
Redmine category:processing/core
On line 362 of voronoi.py, there is the line
except Exception as err:
which is used to swallow all exceptions thrown in the methodvoronoi
. This is generally a bad idea and and is making my life a lot harder while debugging an issue I'm having with the Voronoi Polygons geometry tool.https://github.com/qgis/QGIS/blob/master/python/plugins/processing/algs/qgis/voronoi.py#L362
My suggested fix is to remove this try/except block so that exceptions can propagate up the stack freely. It may be better to instead modify the expect statement to catch only some relevant exceptions that actually should be ignored.
The text was updated successfully, but these errors were encountered: