Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetFeatureInfo with FILTER doesn't work for gpkg - Test added #27650

Closed
qgib opened this issue Sep 12, 2018 · 2 comments
Closed

GetFeatureInfo with FILTER doesn't work for gpkg - Test added #27650

qgib opened this issue Sep 12, 2018 · 2 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server

Comments

@qgib
Copy link
Contributor

qgib commented Sep 12, 2018

Author Name: Tudor Bărăscu (@tudorbarascu)
Original Redmine Issue: 19826
Affected QGIS version: 3.3(master)
Redmine category:qgis_server
Assignee: Paul Blottiere


Test already in:

tests/src/python/test_qgsserver_wms_getfeatureinfo.py

with

@unittest.expectedFailure

   # TODO make filter work with gpkg and move test inside testGetFeatureInfoFilter function
    @unittest.expectedFailure
    def testGetFeatureInfoFilterGPKG(self):
        # 'test_project.qgz' ='test_project.qgs' but with a gpkg source + different fid
        # Regression for #17386 Test getfeatureinfo response xml with gpkg datasource
        # Mind the gap! (the space in the FILTER expression)
        self.wms_request_compare('GetFeatureInfo',
                                 '&layers=testlayer%20%C3%A8%C3%A9&' +
                                 'INFO_FORMAT=text%2Fxml&' +
                                 'width=600&height=400&srs=EPSG%3A3857&' +
                                 'query_layers=testlayer%20%C3%A8%C3%A9&' +
                                 'FEATURE_COUNT=10&FILTER=testlayer%20%C3%A8%C3%A9' + urllib.parse.quote(':"NAME" = \'two\''),
                                 'wms_getfeatureinfo_filter_gpkg',
                                 'test_project.qgz')


Basically the server outpus:

...
 <Layer name="testlayer èé">
  <Feature id="2">
   <Attribute value="2" name="id"/>
   <Attribute value="two" name="name"/>
   <Attribute value="two àò" name="utf8nameè"/>
...

instead of

...
 <Layer name="testlayer èé">
  <Feature id="2">
   <Attribute value="0" name="id"/>
   <Attribute value="2" name="name"/>
   <Attribute value="two" name="utf8nameè"/>
...

It seems the output values index are shifted with +1.

@qgib
Copy link
Contributor Author

qgib commented Sep 27, 2018

Author Name: Paul Blottiere (Paul Blottiere)


  • assigned_to_id was configured as Paul Blottiere

@qgib
Copy link
Contributor Author

qgib commented Oct 7, 2018

Author Name: Paul Blottiere (Paul Blottiere)


Applied in changeset 5a9067e.


  • done_ratio was changed from 0 to 100
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed Oct 7, 2018
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Server Related to QGIS server
Projects
None yet
Development

No branches or pull requests

1 participant