Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme does not work well with new Mac Mojave dark theme #28016

Closed
qgib opened this issue Oct 23, 2018 · 12 comments
Closed

Theme does not work well with new Mac Mojave dark theme #28016

qgib opened this issue Oct 23, 2018 · 12 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Build/Install Related to compiling or installing QGIS

Comments

@qgib
Copy link
Contributor

qgib commented Oct 23, 2018

Author Name: Denis Rouzaud (@3nids)
Original Redmine Issue: 20195
Affected QGIS version: 3.3(master)
Redmine category:mac_os_specific
Assignee: Denis Rouzaud


see image


@qgib
Copy link
Contributor Author

qgib commented Oct 23, 2018

Author Name: Denis Rouzaud (@3nids)


image

@qgib
Copy link
Contributor Author

qgib commented Oct 23, 2018

Author Name: Nyall Dawson (@nyalldawson)


Isn't this fundamentally a qt issue?

@qgib
Copy link
Contributor Author

qgib commented Oct 24, 2018

Author Name: Denis Rouzaud (@3nids)


yes, most likely this one
https://bugreports.qt.io/browse/QTBUG-68891

apparently fixed in upcoming 5.12 (planned on 29.11.2018 https://wiki.qt.io/Qt_5.12_Release)

@qgib
Copy link
Contributor Author

qgib commented Oct 24, 2018

Author Name: Denis Rouzaud (@3nids)


see #8309

@qgib
Copy link
Contributor Author

qgib commented Dec 29, 2018

Author Name: Nyall Dawson (@nyalldawson)


This is fixed, right?

@qgib
Copy link
Contributor Author

qgib commented Dec 31, 2018

Author Name: Giovanni Manghi (@gioman)


  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Jan 15, 2019

Author Name: Seth Fitzsimmons (Seth Fitzsimmons)


This has improved substantially in the nightlies since 3.4.3, although there are still some places that are difficult to use. I've attached a couple screenshots of the Query Builder.

When focused, it's nearly impossible to see text when entering filter expressions (when unfocused, it's actually more readable)


  • 14099 was configured as Screen Shot 2019-01-14 at 6.23.43 PM.png
  • 14098 was configured as Screen Shot 2019-01-14 at 6.23.12 PM.png

@qgib
Copy link
Contributor Author

qgib commented Jan 15, 2019

Author Name: Seth Fitzsimmons (Seth Fitzsimmons)


The Attribute Table form view also suffers from some contrast issues.

In general, black text on UI elements is difficult to read.


  • 14100 was configured as Screen Shot 2019-01-14 at 6.27.29 PM.png
  • 14101 was configured as Screen Shot 2019-01-14 at 6.30.09 PM.png

@qgib
Copy link
Contributor Author

qgib commented Jan 15, 2019

Author Name: Seth Fitzsimmons (Seth Fitzsimmons)


(My screenshots are from Lutra's 20190108 build, so it looks like aafd848, etc. may have addressed these.)

@qgib
Copy link
Contributor Author

qgib commented Jan 15, 2019

Author Name: Mathieu Pellerin - nIRV (Mathieu Pellerin - nIRV)


I think we can close this issue, the original issue reported here was most likely due to a non-fusion style (macintosh here) used against a non-default theme (night mapping). Since January 10 - c7abba0 - we enforce the fusion style on non-default themes.

As for possible additional refinements to night mapping, might be worth opening individual tickets to address specific issues.


EDIT: ignore the above, it's clear not about Night Mapping :)

@qgib
Copy link
Contributor Author

qgib commented Mar 9, 2019

Author Name: Giovanni Manghi (@gioman)


  • status_id was changed from Feedback to Open
  • priority_id was changed from High to Normal

@qgib
Copy link
Contributor Author

qgib commented May 15, 2019

Author Name: Denis Rouzaud (@3nids)


Qt now correctly supports Mac OS dark theme.
There are still some glitches, mainly related to QGIS customizations, but we need specific issues for these.


  • resolution was changed from to up/downstream
  • status_id was changed from Open to Closed

@qgib qgib closed this as completed May 15, 2019
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Build/Install Related to compiling or installing QGIS labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Build/Install Related to compiling or installing QGIS
Projects
None yet
Development

No branches or pull requests

1 participant