Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAGA Fill Sink #28938

Closed
qgib opened this issue Jan 29, 2019 · 6 comments
Closed

SAGA Fill Sink #28938

qgib opened this issue Jan 29, 2019 · 6 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms

Comments

@qgib
Copy link
Contributor

qgib commented Jan 29, 2019

Author Name: Lene Fischer (@LeneFischer)
Original Redmine Issue: 21120
Affected QGIS version: 3.4.4
Redmine category:processing/saga


Trying to use SAGA Fill Sink.
It runs smoothly, but send out an error message. See attached file.
This is both for temp files and for saving as a file.

Secondly it is only possible to save as SDAT - not TIFF


@qgib
Copy link
Contributor Author

qgib commented Jan 29, 2019

Author Name: Giovanni Manghi (@gioman)


In QGIS 3 SAGA only outputs in its native data format, by design.

@qgib
Copy link
Contributor Author

qgib commented Jan 29, 2019

Author Name: Lene Fischer (@LeneFischer)


Why - previously it was in TIF

@qgib
Copy link
Contributor Author

qgib commented Jan 29, 2019

Author Name: Giovanni Manghi (@gioman)


Lene Fischer wrote:

Why - previously it was in TIF

I think this is better answered by Nyall/AlexB as they have re-written Processing.

About the issue reoprted in this ticket, I can't confirm on Win7 and QGIS 3.4.4 with SAGA LTR installed (Processing works with SAGA LTR):

g algorithm�
Algorithm 'Fill sinks' starting�
Input parameters:
{ 'DEM' : 'C:/Users/qgis/Desktop/postgis_training/data/rasters/mdt_clipped_3763.tif', 'MINSLOPE' : 0.01, 'RESULT' : 'C:/Users/qgis/AppData/Local/Temp/processing_8982c772d80e4606b9f8a0599c21fc31/06c4c8e6182640a1a3920f3302dc11d3/RESULT.sdat' }

io_gdal 0 -TRANSFORM 1 -RESAMPLING 3 -GRIDS "C:/Users/qgis/AppData/Local/Temp/processing_8982c772d80e4606b9f8a0599c21fc31/a9947d23e54d445e827e31c4a3f9bc3f/mdtclipped3763.sgrd" -FILES "C:/Users/qgis/Desktop/postgis_training/data/rasters/mdt_clipped_3763.tif"
ta_preprocessor "Fill Sinks (Planchon/Darboux, 2001)" -DEM "C:/Users/qgis/AppData/Local/Temp/processing_8982c772d80e4606b9f8a0599c21fc31/a9947d23e54d445e827e31c4a3f9bc3f/mdtclipped3763.sgrd" -MINSLOPE 0.01 -RESULT "C:/Users/qgis/AppData/Local/Temp/processing_8982c772d80e4606b9f8a0599c21fc31/06c4c8e6182640a1a3920f3302dc11d3/RESULT.sdat"

C:\OSGEO41\bin>set SAGA=C:/OSGEO41/apps\saga-ltr

C:\OSGEO41\bin>set SAGA_MLB=C:/OSGEO41/apps\saga-ltr\modules

C:\OSGEO41\bin>PATH=C:\OSGEO41\apps\qgis\bin;C:\OSGEO41\apps\Python37;C:\OSGEO41\apps\Python37\Scripts;C:\OSGEO41\apps\qt5\bin;C:\OSGEO41\apps\Python27\Scripts;C:\OSGEO41\bin;C:\Windows\system32;C:\Windows;C:\Windows\system32\WBem;C:\OSGEO41\apps\Python37\lib\site-packages\numpy.libs;C:/OSGEO41/apps\saga-ltr;C:/OSGEO41/apps\saga-ltr\modules

C:\OSGEO4~1\bin>saga_cmd io_gdal 0 -TRANSFORM 1 -RESAMPLING 3 -GRIDS "C:/Users/qgis/AppData/Local/Temp/processing_8982c772d80e4606b9f8a0599c21fc31/a9947d23e54d445e827e31c4a3f9bc3f/mdtclipped3763.sgrd" -FILES "C:/Users/qgis/Desktop/postgis_training/data/rasters/mdt_clipped_3763.tif"


## #####

### ##

# ## ## #### #

##### ## #

# ## ##### #

SAGA Version: 2.3.2 (64 bit)


library path: C:\OSGEO4~1\apps\saga-ltr\modules
library name: io_gdal
library : GDAL/OGR
tool : Import Raster
author : O.Conrad (c) 2007 (A.Ringeler)
processors : 2 [2]


Parameters

Grids: No objects
Files: "C:/Users/qgis/Desktop/postgis_training/data/rasters/mdt_clipped_3763.tif"
Select from Multiple Bands:
Alphanumeric Sorting: yes
Transformation: yes
Resampling: B-Spline Interpolation

loading: C:/Users/qgis/Desktop/postgis_training/data/rasters/mdt_clipped_3763.tif

Driver: GTiff

Bands: 1

Rows: 559

Columns: 455

loading: mdt_clipped_3763

C:\OSGEO4~1\bin>saga_cmd ta_preprocessor "Fill Sinks (Planchon/Darboux, 2001)" -DEM "C:/Users/qgis/AppData/Local/Temp/processing_8982c772d80e4606b9f8a0599c21fc31/a9947d23e54d445e827e31c4a3f9bc3f/mdtclipped3763.sgrd" -MINSLOPE 0.01 -RESULT "C:/Users/qgis/AppData/Local/Temp/processing_8982c772d80e4606b9f8a0599c21fc31/06c4c8e6182640a1a3920f3302dc11d3/RESULT.sdat"


## #####

### ##

# ## ## #### #

##### ## #

# ## ##### #

SAGA Version: 2.3.2 (64 bit)


library path: C:\OSGEO4~1\apps\saga-ltr\modules
library name: ta_preprocessor
library : Preprocessing
tool : Fill Sinks (Planchon/Darboux, 2001)
author : Copyrights (c) 2003 by Volker Wichmann
processors : 2 [2]


Load grid: C:/Users/qgis/AppData/Local/Temp/processing_8982c772d80e4606b9f8a0599c21fc31/a9947d23e54d445e827e31c4a3f9bc3f/mdtclipped3763.sgrd...

Parameters

Grid system: 80; 559x 455y; 10283.085928x 54418.184309y
DEM: mdtclipped3763
Filled DEM: Filled DEM
Minimum Slope [Degree]: 0.010000

C:\OSGEO4~1\bin>exit
Execution completed in 28.23 seconds
Results:
{'RESULT': 'C:/Users/qgis/AppData/Local/Temp/processing_8982c772d80e4606b9f8a0599c21fc31/06c4c8e6182640a1a3920f3302dc11d3/RESULT.sdat'}

Loading resulting layers
Algorithm 'Fill sinks' finished


  • regression was changed from 1 to 0
  • status_id was changed from Open to Feedback

@qgib
Copy link
Contributor Author

qgib commented Jan 29, 2019

Author Name: Gabriel De Luca (@gabriel-de-luca)


The error reported was already fixed in @saga-ltr-2.3.2-4@ package.

https://trac.osgeo.org/osgeo4w/ticket/589

@qgib
Copy link
Contributor Author

qgib commented Jan 30, 2019

Author Name: Giovanni Manghi (@gioman)


Gabriel De Luca wrote:

The error reported was already fixed in @saga-ltr-2.3.2-4@ package.

https://trac.osgeo.org/osgeo4w/ticket/589

I'm using this version, so this explains that I don't get the error. Lene can you check what SAGA version have you installed?

@qgib
Copy link
Contributor Author

qgib commented Feb 24, 2019

Author Name: Giovanni Manghi (@gioman)


  • resolution was changed from to no timely feedback
  • status_id was changed from Feedback to Closed

@qgib qgib closed this as completed Feb 24, 2019
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms
Projects
None yet
Development

No branches or pull requests

1 participant