Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regressions in processing "Tile Index" tool #29114

Closed
qgib opened this issue Feb 18, 2019 · 3 comments
Closed

Regressions in processing "Tile Index" tool #29114

qgib opened this issue Feb 18, 2019 · 3 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore

Comments

@qgib
Copy link
Contributor

qgib commented Feb 18, 2019

Author Name: Alister Hood (@AlisterH)
Original Redmine Issue: 21296
Affected QGIS version: 3.4.4
Redmine category:processing/gdal
Assignee: Nyall Dawson


Issue 1:
The processing "Tile Index" tool in QGIS 3.x is equivalent to the one in 2.x. However, "Raster>Miscellaneous>Tile Index..." now uses the processing tool, whereas in 2.x series it was a separate implementation, which must have somehow run the gdaltindex command in a different way, because it could handle more files.
I have 151 rasters here with 88 character long paths.
In both 2.x and 3.x the processing tool produces the error "The command line is too long."
But the tool in the 2.x menu runs perfectly, even though the command it displays is significantly longer (for two reasons - it tries to use the .aux.xml files in the input directory, as well as the tif files, and it also uses \ in each path for all except the last directory separator, rather than /). So, whatever method that tool was using to run the command, it was superior (also note that the whole point of this tool is that you have a LOT of rasters - I don't think 151 is an unreasonably high number).
This could be considered a regression, because the old gdaltools tool which supported more input files has been superseded by the processing tool.
This testing is under Windows, and I doubt this issue would occur on a real operating system.

Issue 2:
If I only select a small number of rasters, the processing tool succeeds in 2.x, but not in 3.x. This is because the path to each raster includes a space, and 3.x is not separately quoting the path to each raster, it is putting one set of quotes around the entire list of input files.
These are the error messages (I have replaced the list of paths, obviously):

ERROR 4: Entire/list of/paths: No such file or directory

Unable to open Entire/list of/paths, skipping.

This problem is a regression by any definition, and I'm guessing it is not specific to Windows, but I haven't checked.

@qgib
Copy link
Contributor Author

qgib commented Feb 18, 2019

Author Name: Nyall Dawson (@nyalldawson)


  • assigned_to_id was configured as Nyall Dawson
  • status_id was changed from Open to In Progress

@qgib
Copy link
Contributor Author

qgib commented Feb 18, 2019

Author Name: Giovanni Manghi (@gioman)


  • priority_id was changed from Normal to High

@qgib
Copy link
Contributor Author

qgib commented Feb 19, 2019

Author Name: Nyall Dawson (@nyalldawson)


Applied in changeset 342c093.


  • done_ratio was changed from 0 to 100
  • status_id was changed from In Progress to Closed

@qgib qgib closed this as completed Feb 19, 2019
@qgib qgib added Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore labels May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! High Priority Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

1 participant