Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QGIS LTR version should notify about LTR releases #34685

Closed
kadarivan opened this issue Feb 26, 2020 · 5 comments
Closed

QGIS LTR version should notify about LTR releases #34685

kadarivan opened this issue Feb 26, 2020 · 5 comments

Comments

@kadarivan
Copy link

Feature description.
Version checking is a great feature, but LTR version should notify about LTR updates only.

qgis-ltr

@kadarivan kadarivan changed the title QGIS LTR sholudn't notify about non-LTR releases QGIS LTR version should notify about LTR releases Feb 26, 2020
@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Mar 29, 2020

Hi @kadarivan, I think this is a bug and a regression.

@gioman, could you please change the tag from "Feature Request" to "Bug"?

@jef-n introduced a mechanism to properly handle the version check through an apache configuration rewrite rule based on the user-agent string sent by QGIS. See #31298 (comment) and #33494.

The QGIS user-agent string was changed to address some WMS problems thanks to @elpaso (see 8bd57ca and #32766 (comment)) since 3.10.2, from something like "Mozilla/5.0 QGIS/3.10.2-A Coruña" to something like "Mozilla/5.0 QGIS/31002".

Probably the apache configuration rewrite rule was not changed accordingly to the change in the user-agent string, then it fails to properly sent the right information about the current version for ltr and non ltr QGIS.

@jef-n
Copy link
Member

jef-n commented Mar 29, 2020

Probably the apache configuration rewrite rule was not changed accordingly to the change in the user-agent string, then it fails to properly sent the right information about the current version for ltr and non ltr QGIS.

Fixed.

@jef-n jef-n closed this as completed Mar 29, 2020
@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Mar 29, 2020

Thanks @jef-n! But now it doesn't work properly for QGIS 3.10.1 and 3.10.0 versions...

@agiudiceandrea
Copy link
Contributor

agiudiceandrea commented Mar 29, 2020

@jef-n 3.10.0 and 3.10.1 versions still send the old style user-agent string: "Mozilla/5.0 QGIS/3.10.0-A Coruña"
Now those versions incorrectly display "New QGIS version available: Visit https://download.qgis.org to get your copy of version 3.12.1", therefore a special rule should be added for these versions.

@agiudiceandrea
Copy link
Contributor

Thank you again! Now it works correctly also for 3.10.0 and 3.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants