Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save credential when is entered in a project where it wasn't originally saved #37632

Open
ismailsunni opened this issue Jul 6, 2020 · 5 comments

Comments

@ismailsunni
Copy link
Contributor

First of all, I am not sure if this a bug or a feature request. Perhaps a bug that can be fixed by adding a feature.

Describe the bug

A credential entered when a WMS layer's credential is changed is not stored.

How to Reproduce

  1. Add a WMS layer from a WMS data source that works without a credential
  2. Save the project
  3. There is a change in the WMS data source, now we need a authentication to access the layer. I have the credential for it
  4. Open the project
  5. It will ask a credential for the WMS layer
  6. Username and Password are entered
  7. Save the project
  8. Open again, it will still ask the username and the password (every time we open the project).

Question Is this expected?

Solution for the User:

  1. Do not enter the credential on step 6, but cancel it
  2. QGIS will show the unavailable layer
  3. Edit the layer source manually, and add the credential
  4. The layer can be opened on QGIS
  5. Saved (the credential is written on the project file), then no need to enter the credential again after that

A possible solution that can be implemented on QGIS:

  • When the user entered the credential (on step 6), QGIS also updates the data source (or at least give a checkbox to update or not). Is this a good addition to QGIS?
  • The credential asked is only accepting basic auth. What about using QGIS authentication?

Alternative

There is this plugin http://plugins.qgis.org/plugins/changeDataSource/ that allows a user to change the data source. But

QGIS and OS versions

QGIS version
3.14.0-Pi
QGIS code revision
9f7028f
Compiled against Qt
5.11.2
Running against Qt
5.11.2
Compiled against GDAL/OGR
3.0.4
Running against GDAL/OGR
3.0.4
Compiled against GEOS
3.8.1-CAPI-1.13.3
Running against GEOS
3.8.1-CAPI-1.13.3
Compiled against SQLite
3.29.0
Running against SQLite
3.29.0
PostgreSQL Client Version
11.5
SpatiaLite Version
4.3.0
QWT Version
6.1.3
QScintilla2 Version
2.10.8
Compiled against PROJ
6.3.2
Running against PROJ
Rel. 6.3.2, May 1st, 2020
OS Version
Windows 10 (10.0)
Active python plugins
latlontools;
Mergin;
qgis_resource_sharing;
QuickOSM;
db_manager;
MetaSearch;
processing;
changeDataSource

@ismailsunni ismailsunni added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Jul 6, 2020
@gioman
Copy link
Contributor

gioman commented Jul 6, 2020

Question Is this expected?

@ismailsunni not sure if is expected, but it always worked this way (also for PostGIS layers for example).

@gioman gioman added the Feedback Waiting on the submitter for answers label Jul 6, 2020
@gioman
Copy link
Contributor

gioman commented Jul 6, 2020

So I guess this could be a feature request.

@ismailsunni
Copy link
Contributor Author

Thanks, @gioman I couldn't change the label to feature request. Would you mind doing it?

@gioman gioman added Feature Request Project and removed Bug Either a bug report, or a bug fix. Let's hope for the latter! Feedback Waiting on the submitter for answers labels Jul 7, 2020
@gioman gioman changed the title Layer Credential is not Saved Save credential when is entered in a project where it wasn't originally saved Jul 7, 2020
@gioman
Copy link
Contributor

gioman commented Jul 7, 2020

Thanks, @gioman I couldn't change the label to feature request. Would you mind doing it?

@ismailsunni done!

@ea-phanvan
Copy link

Any news on this feature request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants