Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when opening Settings > Options dialog in a french environment #44535

Closed
troopa81 opened this issue Aug 3, 2021 · 5 comments
Closed

Crash when opening Settings > Options dialog in a french environment #44535

troopa81 opened this issue Aug 3, 2021 · 5 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption

Comments

@troopa81
Copy link
Contributor

troopa81 commented Aug 3, 2021

What is the bug or the crash?

When I try to open the Settings > Options dialog, with a french locale, QGIS crashes

Steps to reproduce the issue

  1. Start QGIS with french locale
  2. Open Settings > Options dialog
  3. It crashes

Versions

3.21.0-Master QGIS code revision d9a38c1e1a

Additional context

It crashes here because some labels in pageTitles are not translated but the one in pageNames are. Don't know why though.

(gdb) p pageNames
$5 = {["Accélération"] = "mOptionsPageAcceleration", ["Authentification"] = "mOptionsPageAuth", 
  ["Avancé"] = "Avancé", ["Canevas et légende"] = "mOptionsPageMapCanvas", 
  ["Console Python"] = "Console Python", ["Couleurs"] = "mOptionsPageColors", 
  ["GDAL"] = "mOptionsPageGDAL", ["GPSBabel"] = "GPSBabel", ["Général"] = "mOptionsPageGeneral", 
  ["Localisateur"] = "mOptionsLocatorSettings", ["Mises en page"] = "mOptionsPageComposer", 
  ["Numérisation"] = "mOptionsPageDigitizing", 
  ["Outils cartographiques"] = "mOptionsPageMapTools", ["Rendu"] = "mOptionsPageRendering", 
  ["Réseau"] = "mOptionsPageNetwork", ["SCR"] = "mOptionsPageCRS", 
  ["Sources de données"] = "mOptionsPageDataSources", ["Système"] = "mOptionsPageSystem", 
  ["Traitement"] = "Traitement", ["Transformations"] = "mOptionsPageTransformations", 
  ["Variables"] = "mOptionsPageVariables", ["Éditeur de code"] = "Éditeur de code"}
(gdb) p pageTitles
$6 = {"General", "System", "CRS", "Transformations", "Data Sources", "GDAL", "Rendering", 
  "Canvas & Legend", "Map Tools", "Colors", "Digitizing", "Layouts", "Variables", "Authentication", 
  "Network", "GPSBabel", "Locator", "Acceleration", "Éditeur de code", "Console Python", 
  "Traitement", "Avancé"}
@troopa81 troopa81 added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Aug 3, 2021
@nicogodet
Copy link
Member

Ok on OsGeo4W v2 Master 424021a

@jef-n
Copy link
Member

jef-n commented Aug 3, 2021

The nightlies pull in the translations from transifex (scripts/pull_ts.sh). The translations in git are not kept up-to-date until release.

@troopa81
Copy link
Contributor Author

troopa81 commented Aug 3, 2021

The nightlies pull in the translations from transifex (scripts/pull_ts.sh). The translations in git are not kept up-to-date until release.

Isn't it a little bit dangerous that the code rely on up-to-date translations ? That mean that every time a translation is missing for a reason or another, it will crash.

@jef-n
Copy link
Member

jef-n commented Aug 3, 2021

The nightlies pull in the translations from transifex (scripts/pull_ts.sh). The translations in git are not kept up-to-date until release.

Isn't it a little bit dangerous that the code rely on up-to-date translations ? That mean that every time a translation is missing for a reason or another, it will crash.

Sure. I just wanted to say that 424021a might not be any better as d9a38c1e1a.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 18, 2021
@jef-n jef-n closed this as completed in d90a87e Aug 18, 2021
@troopa81
Copy link
Contributor Author

It works now, thanks @jef-n

@github-actions github-actions bot removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Crash/Data Corruption
Projects
None yet
Development

No branches or pull requests

4 participants