Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWG importer usability issues #47230

Closed
2 tasks
roya0045 opened this issue Feb 7, 2022 · 8 comments
Closed
2 tasks

DWG importer usability issues #47230

roya0045 opened this issue Feb 7, 2022 · 8 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting Feedback Waiting on the submitter for answers stale Uh oh! Seems this work is abandoned, and the PR is about to close.

Comments

@roya0045
Copy link
Contributor

roya0045 commented Feb 7, 2022

What is the bug or the crash?

I'm not sure if this should be a bug or a feature request, or many small bugs/UX issues.

  1. The destination GPKG must be selected first.
  2. The destination must already exist, it cannot be created in the dialog
  3. It might or might not work without any apparent reason (Error: Could Not Open Layer List), even with the same dataset that was ok moments ago.
  4. Setting the CRS doesn't seem useful as it gets overwrote( or I just didn't get to change it the one time it worked)
  5. The source pth cannot be changed and the separator are always unix style
  6. The process starts right away when the two layers are 'valid'
  7. You need to specific a group to contain all the other groups for the export in the project.

Steps to reproduce the issue

  1. Project
  2. Import/Export
  3. Import Layers from DWG/DXF

Versions

Old 3.19 could retry with something recent at some point.

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

  • I tried with a new QGIS profile

Additional context

No response

@roya0045 roya0045 added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Feb 7, 2022
@gioman gioman added the DXF/DWG Relating to DXF or DWG importing/exporting label Feb 7, 2022
@gioman
Copy link
Contributor

gioman commented Feb 8, 2022

The destination GPKG must be selected first.

@roya0045 yes, what do you suggest here?

The destination must already exist, it cannot be created in the dialog

When importing? no, the dialog creates the target gpkg if does not exist,

It might or might not work without any apparent reason (Error: Could Not Open Layer List), even with the same dataset that was ok moments ago.

Can you post a sample?

The process starts right away when the two layers are 'valid'

what do you mean?

You need to specific a group to contain all the other groups for the export in the project.

yes, because importing a dwg/dxf can result in very large number of layers being added to the project, having them grouped is not only handy, is basically mandatory.

@gioman gioman added the Feedback Waiting on the submitter for answers label Feb 8, 2022
@roya0045
Copy link
Contributor Author

roya0045 commented Feb 8, 2022

@roya0045 yes, what do you suggest here?

Selecting the dwg to import first, and then set the destination (in and then out, not the opposite)

When importing? no, the dialog creates the target gpkg if does not exist,

You're right you can create a new one, with an existing one if created from the browser it sometimes just doesn't work.

Can you post a sample?

I think the main issue comes from using an already existing geopackage sometimes. It should be replicable with sample dwg, the gpkg seems the be the main blocker not the dwg source. (tested also with a sample from https://knowledge.autodesk.com/support/autocad/downloads/caas/downloads/content/autocad-sample-files.html)

what do you mean?

There is no way to 'start' the process. If you are not doing this locally and across a vpn it can brick QGIS for 10 mins and this doesn't allow you to change the crs once the IN and OUT are set, you are forced to do it after the destination is set but before loading the source, or you'll have to start again.

yes, because importing a dwg/dxf can result in very large number of layers being added to the project, having them grouped is not only handy, is basically mandatory.

It can but they are already grouped individually. It doesn't make sense to force a single 'layer' to be nested into two groups. The user should have the choice to export them under a single group or not, like for any batch import.

@gioman
Copy link
Contributor

gioman commented Feb 8, 2022

Selecting the dwg to import first, and then set the destination (in and then out, not the opposite)

@roya0045 good for a feature request I guess.

I think the main issue comes from using an already existing geopackage sometimes. It should be replicable with sample dwg, the gpkg seems the be the main blocker not the dwg source. (tested also with a sample from https://knowledge.autodesk.com/support/autocad/downloads/caas/downloads/content/autocad-sample-files.html)

so what are the steps to replicate?

There is no way to 'start' the process. If you are not doing this locally and across a vpn it can brick QGIS for 10 mins and this doesn't allow you to change the crs once the IN and OUT are set, you are forced to do it after the destination is set but before loading the source, or you'll have to start again.

I don't understand, Once QGIS hsa finished parsing the DWG and the user filled the "group name" then the OK" button become active, and must be pressed manually. Or are you referring the the parsing process itself, that starts when the DWG is selected? If is the latter then what would be the suggestion? Add a "parse" DWG button? I guess that would also be good for a feature request.

It can but they are already grouped individually. It doesn't make sense to force a single 'layer' to be nested into two groups. The user should have the choice to export them under a single group or not, like for any batch import.

maybe another feature request?

@roya0045
Copy link
Contributor Author

roya0045 commented Feb 8, 2022

@roya0045 good for a feature request I guess.

Sure, though the whole thing would need a lift to fit the QGIS way, the goal of this was just to have a ticket for that widget. I don't mind converting this to a single FR to modernize the widget with the listed elements as outstanding.

so what are the steps to replicate?

  1. In the browser create a gpkg (you can remove or leave the layer you are forced to create)
  2. In the dwg importer set the new gpkg as the destination
  3. load a dwg to import
  4. Error

I don't understand, Once QGIS hsa finished parsing the DWG and the user filled the "group name" then the OK" button become active, and must be pressed manually. Or are you referring the the parsing process itself, that starts when the DWG is selected? If is the latter then what would be the suggestion? Add a "parse" DWG button? I guess that would also be good for a feature request.

The ok only imports the data selected, everything is written to the destination gpkg regardless if you add it to the project or not. Even if you hit Cancel, everything is in the geopackage now.

Also selecting a single element from the list can lead to importing nothing and just creating an empty group (the one blocking you from creating ok), that only happens if the 'layer' imported is not a geospatial layer (I have no clue how a dwg can lead to have so many table dataset but that's out of scope).

maybe another feature request?

Fair

@roya0045
Copy link
Contributor Author

dwg_importer_reowrk
Here is a demo of the reworked widget with most fixes addressed. Using the sublayer dialog allow to group if needed or just import all. Gpkg are reusable (didn't check for the integrity of other layers though). Importing can be done by hitting OK or Import. UI is more intuitive.

@gioman
Copy link
Contributor

gioman commented Feb 21, 2022

Here is a demo of the reworked widget with most fixes addressed. Using the sublayer dialog allow to group if needed or just import all. Gpkg are reusable (didn't check for the integrity of other layers though). Importing can be done by hitting OK or Import. UI is more intuitive.

nice!

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

The QGIS project highly values your report and would love to see it addressed. However, this issue has been left in feedback mode for the last 14 days and is being automatically marked as "stale".
If you would like to continue with this issue, please provide any missing information or answer any open questions. If you could resolve the issue yourself meanwhile, please leave a note for future readers with the same problem and close the issue.
In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this issue.
If there is no further activity on this issue, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Mar 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 5, 2022

While we hate to see this happen, this issue has been automatically closed because it has not had any activity in the last 42 days despite being marked as feedback. If this issue should be reconsidered, please follow the guidelines in the previous comment and reopen this issue.
Or, if you have any further questions, there are also further support channels that can help you.

@github-actions github-actions bot closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting Feedback Waiting on the submitter for answers stale Uh oh! Seems this work is abandoned, and the PR is about to close.
Projects
None yet
Development

No branches or pull requests

2 participants