Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "New ESRI File Geodatabase" action to browser right click menu on directories, rework new gpkg creation UX #49362

Merged
merged 11 commits into from Jul 18, 2022

Conversation

nyalldawson
Copy link
Collaborator

@nyalldawson nyalldawson commented Jul 14, 2022

This PR adds a new action for creating an empty ESRI file geodatabase in the browser context menu (requires GDAL 3.6+).

I've also reworked the UX when selecting New Geopackage from the same menu to immediately create an empty GPKG. Previously you were shown a dialog forcing you to also create an empty layer in that geopackage, which was annoying if you just wanted a empty database ready for importing existing data into. (You were forced to create a dummy layer and delete it immediately after).

I've also fixed a few related issues with handling empty GPKG files.

Peek 2022-07-14 14-55

Also exposes the "vacuum" action for GDB files, and cleans up a few related things

This allows the item gui providers to access the view associated
with an action, e.g. to automatically select something in that
view
on directories

Allows for direct creation of new empty ESRI File geodatabases, ready
for population...
initial creation of a layer in order to make an empty database

This was annoying -- if you wanted to make a new empty gpkg
just to say drag and drop some existing data into, you were
FORCED to create a dummy temporary layer.
@nyalldawson nyalldawson added Feature Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Jul 14, 2022
@github-actions github-actions bot added the GUI/UX Related to QGIS application GUI or User Experience label Jul 14, 2022
@github-actions github-actions bot added this to the 3.28.0 milestone Jul 14, 2022
Copy link
Contributor

@nirvn nirvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice generalization here, and good work.

@nyalldawson nyalldawson merged commit c2183f3 into qgis:master Jul 18, 2022
@nyalldawson nyalldawson deleted the new_database branch July 18, 2022 02:50
@nyalldawson
Copy link
Collaborator Author

Thanks @nirvn!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants