Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDAL prevents LAS/LAZ 1.4 from opening if global_encoding set as 1 #51862

Open
2 tasks
lgouzin opened this issue Feb 14, 2023 · 7 comments
Open
2 tasks

PDAL prevents LAS/LAZ 1.4 from opening if global_encoding set as 1 #51862

lgouzin opened this issue Feb 14, 2023 · 7 comments
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Point Clouds Upstream Needs changes in an upstream library (like Qt, Proj, GDAL, ...)

Comments

@lgouzin
Copy link

lgouzin commented Feb 14, 2023

What is the bug or the crash?

In QGIS 3.26, 3.28, some point-cloud files in LAS or LAZ 1.4 can not get loaded. This seems to be caused by PDAL preventing to read when global_encoding is set to 1

Steps to reproduce the issue

Load a LAS/LAZ 1.4 with Global encoding set to 1. The file does not load and returns an error message. The same file loads fine in other software.

Versions

QGIS version
3.28.3-Firenze
QGIS code revision
c12bcb2
Qt version
5.15.3
Python version
3.9.5
GDAL/OGR version
3.6.2
PROJ version
9.1.1
EPSG Registry database version
v10.076 (2022-08-31)
GEOS version
3.11.1-CAPI-1.17.1
SQLite version
3.39.4
PDAL version
2.4.3
PostgreSQL client version
unknown
SpatiaLite version
5.0.1
QWT version
6.1.6
QScintilla2 version
2.13.1
OS version
Windows 10 Version 2009

Active Python plugins
autoSaver
2.6
LAStools
1.4
nominatim
1.4.2
ntv2_transformations
0.20
OSMDownloader
1.0.3
plugin_reloader
0.9.1
pointsamplingtool
0.5.3
qchainage
3.0.1
QuickOSM
2.0.0
quick_map_services
0.19.31
Serval
3.10.2
slyr_community
4.0.6
db_manager
0.1.20
grassprovider
2.12.99
MetaSearch
0.3.6
processing
2.12.99
sagaprovider
2.12.99

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

  • I tried with a new QGIS profile

Additional context

No response

@lgouzin lgouzin added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Feb 14, 2023
@roya0045
Copy link
Contributor

Is it qgis specific or should this be reported directly in PDAL instead?

@lgouzin
Copy link
Author

lgouzin commented Feb 15, 2023

Good point. PDAL info doesn't read it either.
PDAL: readers.las: Global encoding WKT flag not set for point format 6 - 10.
It shows as fixed though PDAL/PDAL#3803 PDAL/PDAL#3818

@nicogodet nicogodet added the Upstream Needs changes in an upstream library (like Qt, Proj, GDAL, ...) label Feb 15, 2023
@uclaros
Copy link
Contributor

uclaros commented Jan 4, 2024

@lgouzin can you share such a file that fails to load?

@lgouzin
Copy link
Author

lgouzin commented Jan 4, 2024

@sepa-f1
Copy link

sepa-f1 commented Feb 3, 2024

I have the same issue and whatever I tried I couldn't make it work.
I could add LAZ to layer in one of the previous QGIS versions but since the upgrade it stops with error. PDAL is 2.6.0 version and that should have it fixed...

Anyone know exactly where to put the readers.las.nosrs=true parameter that Hobu mentions in https://github.com/PDAL/PDAL/issues/3803?

@uclaros
Copy link
Contributor

uclaros commented Feb 22, 2024

I'd argue this is not a bug, rather a strict implementation of the laz spec by pdal.

Global encoding is a bit field, comprising of 16 individual bits, 5 of which are actually used:

bit usage
bit0 GPS time type
bit1 Waveform Data Packets Internal
bit2 Waveform Data Packets External
bit3 Synthetic Return Numbers
bit4 WKT
bit5-bit15 Must be zero

Point formats 6-10 (laz 1.4) require by the laz spec a WKT srs definition which also means bit 4 to be set to 1.

Your las file properly includes a WKT srs definition but the global encoding value is bad, as it is 1 in decimal for the whole value, ie 0x01 in hex or 0b00000001 which translates to the following bits:

bit usage
1 GPS time type
0 Waveform Data Packets Internal
0 Waveform Data Packets External
0 Synthetic Return Numbers
0 WKT

making it essentially invalid according to the laz spec, which is why pdal also doesn't read it.

I believe the intention there was to have only the wkt bit set, ie 0b00010000 (0x10 in hex or 16 in dec) or both the gps time type and wkt bits, ie 0b00010001 (0x11 in hex or 17 in dec)

@lgouzin
Copy link
Author

lgouzin commented Feb 22, 2024

That's right, global_encoding should not be 1 in this dataset.
I believe it is still possible to display the data without forcing the end-user to reprocess their LAZ files?
Other software can display the data. And GPS time can be figured out between week seconds or standard/adjusted GPS time.
Maybe something a bit like a vector layer with a funny ESRI SRID without EPSG. The data get displayed anyway and show 'unknown', leaving the user the choice to read the SRID description and then assign another one if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Point Clouds Upstream Needs changes in an upstream library (like Qt, Proj, GDAL, ...)
Projects
None yet
Development

No branches or pull requests

5 participants