Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more expression checks in the Processing raster calculator algorithms #55386

Open
2 tasks
DelazJ opened this issue Nov 23, 2023 · 1 comment
Open
2 tasks
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore

Comments

@DelazJ
Copy link
Contributor

DelazJ commented Nov 23, 2023

What is the bug or the crash?

In the old "Raster calculator" algorithm and the one in "Raster" menu, there is a check done on validity of the expression you write. The result is displayed at the bottom of the expression textbox.
In the new (virtual or not) "Raster calculator" algorithms, there is no feedback about expression validity. The label widget that displays the result is still present in the ui file at the bottom of the expression box, but it does not seem reused.

Steps to reproduce the issue

  1. Add raster layer(s) to a project
  2. Open Processing Raster calculator algorithm
  3. Press the expression button, opening the "Raster calculator expression" widget
  4. Type anything you want and see that nothing happens and you can safely hit the OK button (in vector context, an invalid expression use to disable the OK button)

raster_calc_new

In old version there was no specific widget for expressions but you'd get a red "Expression is not valid"
Capture d’écran 2023-11-23 à 16 26 40

Versions

master (a161141) on Windows 10

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

Additional context

No response

@DelazJ DelazJ added Processing Relating to QGIS Processing framework or individual Processing algorithms Bug Either a bug report, or a bug fix. Let's hope for the latter! labels Nov 23, 2023
@agiudiceandrea agiudiceandrea added the Regression Something which used to work, but doesn't anymore label Dec 18, 2023
@fpirotti
Copy link

+1 on this issue... the new raster calculator seems to have lost a lot of the positive aspects. As others suggested a "recent expressions" would also be great. Also integration with model builder will be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! Processing Relating to QGIS Processing framework or individual Processing algorithms Regression Something which used to work, but doesn't anymore
Projects
None yet
Development

No branches or pull requests

3 participants