Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear 'title' provenance in DXF Export's 'use layer title as name' option #57012

Closed
1 of 2 tasks
gacarrillor opened this issue Apr 1, 2024 · 1 comment
Closed
1 of 2 tasks
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting GUI/UX Related to QGIS application GUI or User Experience

Comments

@gacarrillor
Copy link
Member

What is the bug or the crash?

Before creating a PR to fix this, I'd like to know if there is any consensus on this matter. I wasn't sure on whether to post this issue in QGIS or QGIS Docs, but finally thought it fits better here in the QGIS repo.

The DXF Export dialog includes an option called Use layer title as name if set. However, it is not clear for users where is this layer title taken from.

A first guess could be the layer's metadata, but that's not correct. Currently, this layer title is taken instead from the QGIS Server properties. Apparently that was the original intention (see 555b7a4), so this is not a bug, it's just a matter of making it clear for users.

Documentation for this option does not help to reduce the confusion either.

Suggestion

I'd suggest that we add a tooltip to this option stating where the title is taken from. Namely, something like this:

Layer title is taken from QGIS Server properties.

The checkbox text would remain untouched.
Documentation will be updated accordingly.

Would that (specially the wording) make sense for you guys?
@DelazJ @nirvn @jef-n

Steps to reproduce the issue

  1. Go to Project ► Import/Export ► Export Project to DXF…

The option is the first check box on the bottom group.

image

Versions

QGIS version 3.37.0-Master QGIS code revision 721acbb43a5
Qt version 5.15.3
Python version 3.10.12
GDAL/OGR version 3.4.1
PROJ version 8.2.1
EPSG Registry database version v10.041 (2021-12-03)
GEOS version 3.11.1-CAPI-1.17.1
SQLite version 3.37.2
PDAL version 2.3.0
PostgreSQL client version 14.11 (Ubuntu 14.11-0ubuntu0.22.04.1)
SpatiaLite version 5.0.1
QWT version 6.1.4
QScintilla2 version 2.11.6
OS version Ubuntu 22.04.2 LTS
       
This copy of QGIS writes debugging output.
       
Active Python plugins
AppendFeaturesToLayer 2.0.0
InvisibleLayersAndGroups 2.1
asistente_ladm_col 5.0.0-dev
QgisModelBaker 6.3.2.1
multilayerselect 1.5.0
valuetool 3.0.15
quick_map_services 0.19.33
LoadThemAll 3.5.0-beta-2403011
processing 2.12.99
grassprovider 2.12.99
db_manager 0.1.20
MetaSearch 0.3.6
QGIS version 3.37.0-Master QGIS code revision [721acbb43a5](https://github.com/qgis/QGIS/commit/721acbb43a5) Qt version 5.15.3 Python version 3.10.12 GDAL/OGR version 3.4.1 PROJ version 8.2.1 EPSG Registry database version v10.041 (2021-12-03) GEOS version 3.11.1-CAPI-1.17.1 SQLite version 3.37.2 PDAL version 2.3.0 PostgreSQL client version 14.11 (Ubuntu 14.11-0ubuntu0.22.04.1) SpatiaLite version 5.0.1 QWT version 6.1.4 QScintilla2 version 2.11.6 OS version Ubuntu 22.04.2 LTS

This copy of QGIS writes debugging output.

Active Python plugins
AppendFeaturesToLayer
2.0.0
InvisibleLayersAndGroups
2.1
asistente_ladm_col
5.0.0-dev
QgisModelBaker
6.3.2.1
multilayerselect
1.5.0
valuetool
3.0.15
quick_map_services
0.19.33
LoadThemAll
3.5.0-beta-2403011
processing
2.12.99
grassprovider
2.12.99
db_manager
0.1.20
MetaSearch
0.3.6

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

Additional context

No response

@gacarrillor gacarrillor added Bug Either a bug report, or a bug fix. Let's hope for the latter! GUI/UX Related to QGIS application GUI or User Experience DXF/DWG Relating to DXF or DWG importing/exporting labels Apr 1, 2024
@gacarrillor
Copy link
Member Author

Just for the record, this has been adjusted in https://github.com/qgis/QGIS/pull/57103/files#diff-3aa9d0ace8d624e995f382d12f585ff77e0bc69b7c0082a284d16db1ee20b605R2387 to always prefer layer metadata over QGIS Server properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter! DXF/DWG Relating to DXF or DWG importing/exporting GUI/UX Related to QGIS application GUI or User Experience
Projects
None yet
Development

No branches or pull requests

1 participant