Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private header is included in public header #57294

Closed
2 tasks
m-kuhn opened this issue Apr 30, 2024 · 0 comments · Fixed by #57295
Closed
2 tasks

Private header is included in public header #57294

m-kuhn opened this issue Apr 30, 2024 · 0 comments · Fixed by #57295
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!

Comments

@m-kuhn
Copy link
Member

m-kuhn commented Apr 30, 2024

What is the bug or the crash?

When including qgs3dutils.h in a custom application the build will fail because it includes a private header qgsraycastingutils_p.h.

Steps to reproduce the issue

  1. Create an app
  2. Include qgs3dutils.h
  3. Build

Versions

at least 3.34 and 3.36

Supported QGIS version

  • I'm running a supported QGIS version according to the roadmap.

New profile

Additional context

Introduced in b371267

CC @uclaros
@m-kuhn m-kuhn added the Bug Either a bug report, or a bug fix. Let's hope for the latter! label Apr 30, 2024
This was referenced Apr 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Either a bug report, or a bug fix. Let's hope for the latter!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[3d] Do not include private header from public header m-kuhn/QGIS
1 participant
@m-kuhn