UI improvements in symbol layer widgets

[tecoholic]

Hello @NathanW2, @wonder-sk and @etiennesky

I have made a number of UI changed in the Symbol layer properties widgets.

• Mostly corrected the alignment of the parameter input fields to be in line with the top Layer Type combo.
• Then removed a few buttons which were meant to call Symbol Editor for sub-symbols.
• Tweaked the color selection buttons so that they show color on themselves properly.

Test it out and merge if you like, if there is anything bothering do let me know. I am chipping away things little be little expect small updates now and then.

[etiennesky]

Arun - I just noticed that color ramps (but not symbols) are duplicated in the database when you save an existing symbol. Can you have a look please?

[tecoholic]

@etiennesky I missed the UNIQUE keyword in the symbol_xml2db.py script for colorramp names. Look at https://github.com/qgis/Quantum-GIS/blob/master/scripts/symbol_xml2db.py#L39 . Could you add that and recreate the DB for me please.

Update: But then, there is something to fix in the code as well. I will fix it and let you know.

[tecoholic]

Ok, found the bug. In line 191 here-> https://github.com/qgis/Quantum-GIS/blob/master/src/core/symbology-ng/qgsstylev2.cpp#L191 , the mSymbols.contains() is supposed to be mColorRamps.contains() or colorRampNames().contains(). That fixes it. I hope you can do that :)

[etiennesky]

Hi, will do both, thanks for the fixes.

[etiennesky]

I'll let others review this request, because I can't understand the differences and don't want to interfere.

[tecoholic]

@NathanW2 and @wonder-sk : Just a reminder, this pull request has been long standing. I guess you both are busy, otherwise it would have been evaluated long ago, I just wanted to remind you to consider this when you find enough free time.

[wonder-sk]

I have been on vacation last four weeks - I should be able to look at it
during the next week - please ping me if I forget!

[NathanW2]

@tecoholic sorry man just got busy and didn't get a chance to take a look. Slowing getting back into the grove of things.

[wonder-sk]

Changes look good - merged - and thanks for your patience!