Transfer ownership of widgets to C++ when pushed to the QgsMessageBar #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
SIP part looks okay, though QgsMessageBar would probably enjoy some improvements, of course that's not related to this fix.... e.g. the handling of ownerships of objects is not very clear (at least at the first sight), the createMessage() methods should probably have /Factory/ annotation and I see no point in assigning a parent in createMessage() as the widget will be reparented to the message bar. |
wonder-sk
added a commit
that referenced
this pull request
Dec 28, 2012
Transfer ownership of widgets to C++ when pushed to the QgsMessageBar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, createMessage transfers ownership of the created widget to python, but when pushed to the message bar, ownership is not transfered back.
This creates the need for python to keep a reference to the message until this gets removed from the messagebar. This is too much overhead for a simple message to be shown.
I'm not sure if the widget needs to be deleted only if its parent is the QgsMessageBar (as in the pull-request now) or in any case, because python will loose ownership anyway and memory will be leaked.
Any help from a sip expert is appreciated.