fix editable attribute of joined fields (fix #7739)

[minorua]

fixes http://hub.qgis.org/issues/7739

[gioman]

Hi, can this patch be committed so I can test it and then eventually close the ticket? Thanks!

[m-kuhn]

It works, but it's still easy to turn the field to an editable one in the layer properties. Is this intended behavior?

[m-kuhn]

Sidenote: Would it not be easier to just set the editable state in QgsAttributeEditor::createAttributeEditor?

[minorua]

It works, but it's still easy to turn the field to an editable one in the layer properties. Is this intended behavior?

No. It would be better to disable/hide Edit-widget-button/editable-checkbox of joined fields in the layer properties dialog.

[m-kuhn]

PS:
Just check for the FieldOrigin in QgsVectorLayer::fieldEditable() would probably be even cleaner. (But the buttons still need to be adjusted)

[minorua]

updated the commit and add a commit to disable edit type buttons of joined fields (the previous one is minorua@7f0bbf4).

[m-kuhn]

Did you disable the whole widget config dialog? Should not only the editable button be disabled?

And what do you think about simply checking the FieldOrigin in fieldEditable() ?

[minorua]

Those were enough for me. Any improvement about this patch is welcome. :)

[m-kuhn]

Sorry, I did not want to steal your time :-)
But do you agree to the remarks I made?

[minorua]

But do you agree to the remarks I made?

@Matthias-Kuhn You know better than I do. I'll cooperate with the test if you modify something about this issue.

[m-kuhn]

I wasn't sure if I overlooked something, these were just ideas. I'll try to come up with a patch...

[m-kuhn]

@minorua would you be able to test the referenced pull request.

[minorua]

@Matthias-Kuhn Great! I've just tested your branch. All (attribute list in the properties, edit form and writing xml) works expectedly. Thanks!

[m-kuhn]

Merged. Thank you for your work and the testing.