solved Issue7550 #714
Closed
solved Issue7550 #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implemented getPrimaryKey member function of QgsSpatiaLiteProvider - in addFeatures, if an attribute is a primary key, its value is set to NULL so that sqlite generates a value automagically
for that - modified the test to have multiple column primary key (it fails for the moment
- the feature modification stops (in edit buffer) once an error is found - the test has been modified to refelect the real problem: the data corruption, and not the commit failure if primary key are not unique
|
sorry, several commits, I will do a better PR latter today. |
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit changes stop to edit features once an error is found. The aim is to minimize DB alteration in case something goes wrong.