Dialogs quality problems and consistency : replace "non standard" icons

[DelazJ]

Throughout QGIS, dialogs have quality problems. It would be nice if someone could check all dialogs for the following problems: replacing "non standard" icons. We still have some inconsitently
used icons (such as the expression builder icon) used throughout qgis.

List of icons (to be completed):

• expression builder
• ...

[DelazJ]

@nyalldawson, Any idea on why we have both mIconExpression and mIconExpressionEditorOpen? what would be the difference ?

[nyalldawson]

@DelazJ I the believe one with '...' is supposed to be used for buttons or other actions which open a new expression builder dialog. The other is a generic icon to be used to show that something is set to an expression.
Possible the '...' one is redundant, since we don't use '...' in other button icons (eg the projection selector combobox button). @dakcarto looks like you introduced some of these, can you explain the rationale here?

[DelazJ]

Trying to add icons where they should be, I'm looking for good practices. Sometimes, same change in two different files do not have same result (icon shown in one and not in the other one).
Given the description of a qtoolbutton (questions concern also qpusbutton) below which I'd like to only show an icon:

• should the property text be kept ? with its ... value?
• should this line <iconset resource="../../images/images.qrc"> be present? or a relative path to the image can/should be set in the line that follows?
• Then what about the following lines? Are they still needed (present not in all files):

 <resources>
  <include location="../../images/images.qrc"/>
</resources>

The aim is to have an exemple of what is the optimal code for icon insertion and not overload the file with unneeded matters.

<widget class="QToolButton" name="mBrowseButton">
 <property name="toolTip">
   <string>Browse for action</string>
 </property>
 <property name="statusTip">
   <string>Click to browse for an action</string>
 </property>
 <property name="whatsThis">
  <string>Clicking the button will let you select an application to use as the action</string>
 </property>
 <property name="text">
  <string>...</string>
 </property>
 <property name="icon">
  <iconset resource="../../images/images.qrc">
   <normaloff>:/images/themes/default/mActionFileOpen.svg</normaloff>:/images/themes/default/mActionFileOpen.svg</iconset>
 </property>
</widget>

@nirvn @nyalldawson ?