Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learning how to contribute #1057

Closed
lecneri opened this issue Apr 4, 2024 · 1 comment
Closed

Learning how to contribute #1057

lecneri opened this issue Apr 4, 2024 · 1 comment

Comments

@lecneri
Copy link

lecneri commented Apr 4, 2024

Hello,

A friend want to contribute with the project because he faced some hardtime accessing mobile, but not sure how to quite do it. And asked me to help.
He downloaded dist version 3.20.1 of openlayers.org and replaced ol.js and ol.css of resources folder.
Because of it, he had to alter resources/ol-layerswitcher.js at line 300
FROM
var descendantVisibility = group.getLayersArray().map(function (l) {
To
var descendantVisibility = group.getLayers().getArray().map(function (l) {
We'd like to know how can we submit and contribute to this project doing this modification, and doing a PR

@andreaordonselli
Copy link
Collaborator

andreaordonselli commented Apr 4, 2024

Thank you for wanting to contribute to the project.
The guide to create a pull request is officially explained by github here https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request

In any case it doesn't seem like a good idea to replace the current version of openlayers with an older one.
With this commit openlayers is at version 6.4.3:
533eaba

What we need to do is go from version 6 to version 9, not go back to 3
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants