Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConvexRegionSelector and SwingTrajectoryPlanner #11

Open
kslee12 opened this issue May 19, 2024 · 0 comments
Open

ConvexRegionSelector and SwingTrajectoryPlanner #11

kslee12 opened this issue May 19, 2024 · 0 comments

Comments

@kslee12
Copy link

kslee12 commented May 19, 2024

Thank you for the great work.

This code has been a valuable learning resource for me, and I hope it will be helpful to others as well.

  1. I found that lastStandMiddleTime is not updated in ConvexRegionSelector.cpp.
    Although I could not fully understand the code, it might be fixed as follows:
if (!numerics::almost_eq(standMiddleTime, lastStandMiddleTime)) {
     lastStandMiddleTime = standMiddleTime
...
  1. Although the code works great, I think there are some improvements to be made in the swing trajectory generation :
  • During steps, the swing trajectory passes through the terrain, which might be related to the collision penalty.
  • On slopes, the swing trajectory does not seem to work properly. The trajectory is generated too high, especially showing a tendency to rise on downhill slopes. I tried to solve this problem (by modifying foot height or adding some coding tricks), but it still does not work well.
    slope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant