Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize task parameters #907

Open
alecandido opened this issue Jun 27, 2024 · 1 comment
Open

Deserialize task parameters #907

alecandido opened this issue Jun 27, 2024 · 1 comment

Comments

@alecandido
Copy link
Member

The parameters specified either in the runcard or directly to run_protocol are not deserialized until they are queried, and they are just loaded into the original Action, as a generic dictionary.

While this was a temporary workaround, to avoid a more complicate implementation, we should now take the longer track, and validate the parameters as soon as possible, i.e. when the Task is created, at the beginning of run_protocol.

While we could preload all tasks at the beginning of a sequential execution, since they are all known from the very beginning, we can consider this an optimization for the specific case of runcards.

@alecandido
Copy link
Member Author

alecandido commented Jul 1, 2024

Since it was confusing myself: it just means that Action should validate the parameters (loading them in the suitable class), instead of holding the dictionary as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant