Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

关于中文支持 #15

Closed
hawtim opened this issue Oct 18, 2020 · 4 comments
Closed

关于中文支持 #15

hawtim opened this issue Oct 18, 2020 · 4 comments

Comments

@hawtim
Copy link
Collaborator

hawtim commented Oct 18, 2020

我在 fork 仓库下建了个分支，https://github.com/hawtim/YesPlayMusic/tree/i18n
用 vue-i18n 简单的实现了一下中文支持
有空可以看看是否符合 TODO 中文支持的实现
@qier222
Copy link
Owner

qier222 commented Oct 19, 2020

看起来没问题，message最好再分几层，比如navbar的explore可以是message.nav.explore

@hawtim
Copy link
Collaborator Author

hawtim commented Oct 19, 2020

嗯是个好建议。我打算把顶部条的中文先实现，然后推个 PR ，你看怎样。

@qier222
Copy link
Owner

qier222 commented Oct 19, 2020

@hawtim 可以哦

@hawtim
Copy link
Collaborator Author

hawtim commented Oct 19, 2020

PR 已提交 #23

@qier222 qier222 closed this as completed Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hawtim @qier222