Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable websocket communication #3362

Merged
merged 1 commit into from
Feb 26, 2024
Merged

enable websocket communication #3362

merged 1 commit into from
Feb 26, 2024

Conversation

sjanssen2
Copy link
Contributor

@sjanssen2 sjanssen2 commented Feb 16, 2024

Addressing #3361
extend the nginx example configuration file such that communication through WebSockets is automatically enabled.
I am not 100% sure if

  • the location definition is comprehensive. There might be more endpoints that need WebSocket communication
  • the current settings cause unintended side effects

extend the nginx example configuration file such that communication through WebSockets is automatically enabled
@coveralls
Copy link

Coverage Status

coverage: 92.832%. remained the same
when pulling 224e3e1 on sjanssen2:patch-9
into 58e15a4 on qiita-spots:dev.

@antgonza
Copy link
Member

Thank you @sjanssen2; if we can't confirm the list of things in your last comment would it be better to add these changes and details to the INSTALL.md document? That way is available and admins/users can decide if they need to add these changes or not.

@sjanssen2
Copy link
Contributor Author

I @antgonza, last week, I have checked the added configuration to nginx with our local admins. They couldn't find any security related misconfiguration. Thus, I would say the second point is checked, while the first one about the locations is something you can answer best.

@antgonza
Copy link
Member

To be honest, I don't recall having to add those lines (or anything similar) to our nginx configuration but it sounds like it worked for you and your sys-admin. Thus, I think is fine to merge. Thank you.

@antgonza antgonza merged commit 1c3a473 into qiita-spots:dev Feb 26, 2024
4 checks passed
@sjanssen2
Copy link
Contributor Author

Seems to depend on the actual routing of the traffic. Admins told me, we are running nginx behind an HA proxy which routes external HTTPS requests internally via HTTP. In this case, the additional lines are also probably not necessary - but wouldn't hurt either.

@antgonza antgonza linked an issue May 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nginx missing websocket proxy
3 participants