Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use abstract instead of open modfier #9

Closed
igorwojda opened this issue Jan 4, 2019 · 2 comments
Closed

Use abstract instead of open modfier #9

igorwojda opened this issue Jan 4, 2019 · 2 comments

Comments

@igorwojda
Copy link

https://github.com/qingmei2/MVVM-Rhine/blob/9b408036eb73c013736b35668b90053f64fa050d/rhine/src/main/java/com/qingmei2/rhine/base/view/activity/InjectionActivity.kt#L12

I think abstract modifier would be better suited here and in the BaseActivity and AutoDisposeActivity
@qingmei2
Copy link
Owner

qingmei2 commented Jan 5, 2019

@igorwojda

Yes, that would be better 👍 I will make changes when I am free 😄 .

@qingmei2
Copy link
Owner

qingmei2 commented Jan 5, 2019 •
edited

Thank you for reminding me, the code has been modified:

a9c2b12

@qingmei2 qingmei2 closed this as completed Jan 5, 2019
@qingmei2 qingmei2 reopened this Jan 5, 2019
@qingmei2 qingmei2 closed this as completed Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igorwojda @qingmei2