Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The different RR in test.py and eval.py #45

Closed
Hui-design opened this issue Oct 30, 2022 · 6 comments
Closed

The different RR in test.py and eval.py #45

Hui-design opened this issue Oct 30, 2022 · 6 comments

Comments

@Hui-design
Copy link

Hello, thank you for you amazing work again.
When I evaluated on 3DMatch, I found the RR reported by test.py and eval.py are very different, what makes this difference?

@35p32
Copy link

35p32 commented Nov 4, 2022

The definition of whether one pair of point cloud was successfully registered in test and eval stage is different. Check the code.

@qinzheng93
Copy link
Owner

RR in test.py is defined as mean error, while RR in eval.py is defined as RMSE following Redwood. Use the results from eval.py in your paper.

@Hui-design
Copy link
Author

Thank you for your reply. I agree with that. Apart from the definition of RR, I also find that you remove consecutive frames (may following predator) in eval.py, which also makes the dataset more difficult, resulting in the reduction in RR from "test" to "eval". Is my understanding correct?

@qinzheng93
Copy link
Owner

Yes. The convention of skipping consecutive frames is from 3DMatch.

@sss752990616
Copy link

Hi @qinzheng93,

Thanks for your great work. As a beginner in this area, I just have one follow-up question, what is the main difference between test.py and eval.py, and why do we need both of them? It looks like they are doing similar things.

@sss752990616
Copy link

And one more question is that according to my reading of the code for eval.py and test.py, they look like both evaluate the same dataset. Not sure if my observation is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants