Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ZNEStrategy #4

Closed
pedrorrivero opened this issue Oct 19, 2022 · 0 comments · Fixed by #20
Closed

Refactor ZNEStrategy #4

pedrorrivero opened this issue Oct 19, 2022 · 0 comments · Fixed by #20
Assignees
@pedrorrivero
Labels
DC-4 Difficulty class 4/5 → Multidomain knowledge enhancement New non-feature request (e.g. performance) PL-2 Priority level 2/5 → Medium-high

Comments

@pedrorrivero
Copy link
Member

What is the expected enhancement?

With the new interface in Qiskit Terra 0.22, ZNEStrategy no longer needs to be a frozen class. On top of that, all the internal functionality that it holds (now) makes it not very well suited to be a dataclass altogether; instead, something more tailored would be preferred.
@pedrorrivero pedrorrivero added enhancement New non-feature request (e.g. performance) DC-4 Difficulty class 4/5 → Multidomain knowledge PL-2 Priority level 2/5 → Medium-high labels Oct 19, 2022
@pedrorrivero pedrorrivero added this to the 1.0.0 milestone Oct 19, 2022
@pedrorrivero pedrorrivero mentioned this issue Oct 20, 2022
Closed
This was referenced Oct 28, 2022
Merged
Merged
@pedrorrivero pedrorrivero removed this from the 1.0.0 milestone Nov 7, 2022
@pedrorrivero pedrorrivero self-assigned this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pedrorrivero pedrorrivero

Labels
DC-4 Difficulty class 4/5 → Multidomain knowledge enhancement New non-feature request (e.g. performance) PL-2 Priority level 2/5 → Medium-high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(zne_strategy): discontinue frozen dataclass qiskit-community/prototype-zne
1 participant
@pedrorrivero