Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockFidelity in test_fidelity_qkernel incompatibility #729

Closed
woodsp-ibm opened this issue Dec 14, 2023 · 0 comments · Fixed by #761
Closed

MockFidelity in test_fidelity_qkernel incompatibility #729

woodsp-ibm opened this issue Dec 14, 2023 · 0 comments · Fixed by #761

Comments

@woodsp-ibm
Copy link
Member

Background: There was an issue with fidelities in Qiskit Algorithms exhibiting random failures and was corrected by qiskit-community/qiskit-algorithms#92 This needed to change what was computed in the threading context of the job and a change to the private base class method _run was made - it now returns a job that can fetch the result rather than the result.

This affects the MockFidelity class where that is used in tests.

class MockFidelity(BaseStateFidelity):

Some tests error this way AttributeError: 'StateFidelityResult' object has no attribute 'submit' since now a job is expected.

This internal change will come about in the next release of Qiskit Algorithms. I noticed the failure when running ML tests locally as I have algorithms installed off the repo main branch where that change already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant