Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate qiskit_algorithms following end-of-support #811

Open
7 tasks done
edoaltamura opened this issue Jul 1, 2024 · 2 comments · May be fixed by #817
Open
7 tasks done

Migrate qiskit_algorithms following end-of-support #811

edoaltamura opened this issue Jul 1, 2024 · 2 comments · May be fixed by #817
Assignees
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@edoaltamura
Copy link
Collaborator

edoaltamura commented Jul 1, 2024

What should we add?

Qiskit algorithms, which Qiskit machine-learning (ML) depends on, is no longer officially supported as of qiskit-community/qiskit-algorithms@4247d06. To continue improving the subset of Algorithms features that are relevant to Qiskit machine-learning, it has been proposed to migrate those from Algorithms to ML.

This proposed action would migrate three sections of Qiskit algorithms.

Gradients https://github.com/qiskit-community/qiskit-algorithms/tree/main/qiskit_algorithms/gradients

State fidelities https://github.com/qiskit-community/qiskit-algorithms/tree/main/qiskit_algorithms/state_fidelities

  • Base state fidelity
  • Compute-uncompute
  • State fidelity result

Optimizers https://github.com/qiskit-community/qiskit-algorithms/tree/main/qiskit_algorithms/optimizers

The proposed migration could be applied in two stages.

  • First, the optimizers could be migrated alongside their respective wrapper classes.
  • Second, the downstream usage could be tweaked so that the wrapper classes can be dropped and the optimizers imported directly from the original dependency. The feasibility of this step is to be evaluated after the standard migration.

Utilities


The development will take place in this fork branch: https://github.com/OkuyanBoga/hc-qiskit-machine-learning/tree/migrate-algo.

@declanmillar
Copy link
Contributor

I think this all sounds sensible. I suppose we'll also need to migrate the unit tests, and the tutorials may need to be modified to reflect the reduced functionality. Is the plan to migrate all the dependencies as-is before modifying them for compatibility with ISACircuits/V2 Primitives?

@edoaltamura
Copy link
Collaborator Author

This would be a valid solution. Migrating the relevant parts first would mean that we would only have to update the ISA/V2 compatibility on this subset of the code for the moment.
Thanks for pointing out the tests! We definitely need those too to maintain code coverage. I have merged the files and the tests will be in the hc- fork by tomorrow.

@edoaltamura edoaltamura linked a pull request Jul 11, 2024 that will close this issue
@edoaltamura edoaltamura self-assigned this Jul 11, 2024
@edoaltamura edoaltamura added this to the 0.8.0 milestone Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants