Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API to allow QubitMapper where QubitConverter is used #972

Closed
mrossinek opened this issue Nov 17, 2022 · 1 comment · Fixed by #999
Closed

Update API to allow QubitMapper where QubitConverter is used #972

mrossinek opened this issue Nov 17, 2022 · 1 comment · Fixed by #999
Assignees
Labels
type: feature request New feature or request
Milestone

Comments

@mrossinek
Copy link
Member

What should we add?

This will be the first step of #967 because it can be largely parallelized with Qiskit/qiskit#9140.

The idea here is to update all occurrences of QubitConverter in the public API to also allow direct usage of QubitMappers. This will require potential isinstance checks to differentiate the two cases from another, but for the transition period while QubitConverter is being deprecated there is no way around this.

Until later parts of #967 are completed, some mappers will not provide the full functionality that is available through the QubitConverter but for the sake of not having to do all the changes at once in one massive PR this is okay.

Unittests should be added to assert the working cases.

@mrossinek mrossinek added the type: feature request New feature or request label Nov 17, 2022
@mrossinek mrossinek added this to the 0.6.0 milestone Nov 17, 2022
@Anthony-Gandon
Copy link
Contributor

I can contribute here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants