Ecosystem configuration refactoring

[IceKhan13]

What is the expected behavior?

Review ecosystem configuration files.

Currently configuration supports extra dependencies and tests commands and only works for python repositories and using tox as testing and configuration (which is good actually and follows other Qiskit projects)

We need at least to add extra configurable commands to run style checks and coverage.

Epic: #9

[mickahell]

bouh :p

[IceKhan13]

I think we need to address number of issue in current configuration setup:

1. rename file appropriately. qe_config.json is not the best option
2. we have this snippet in 3 runner files (coverage, tests, lint) which is not good. We should hide it inside configuration class or refactor somehow https://github.com/qiskit-community/ecosystem/blob/ac1c4a05ec1150f33593ce64dfeffca89465aa3a/ecosystem/runners/python_coverages_runner.py#L41-L50
3. Optional: move from json to yaml (as all configs usually in yaml)
4. Maybe store configuration class inside Repository class and store in db too. So this configuration will be deafult: if repository has config file -> we use it, if not -> we use config stored in DB

[mickahell]

#39 (comment)

1. rename file appropriately. qe_config.json is not the best option

Ok, for a more clear name (config_file, project_file, project_config, testing_config, ... ?)

---

2. we have this snippet in 3 runner files (coverage, tests, lint) which is not good. We should hide it inside configuration class or refactor somehow

Yes, we could make a simple function in the runner class and call it

---

3. Optional: move from json to yaml (as all configs usually in yaml)

hmm, does it really mater ? I don't know the usual best practice, but I find the json file pretty clear to read and easy to fill

---

4. Maybe store configuration class inside Repository class and store in db too. So this configuration will be deafult: if repository has config file -> we use it, if not -> we use config stored in DB

Hmm.. for me if the project don't have the config file, we just should use the default parameters and that's it. I don't see the place of these parameters in the db.
And, if a project has a config file I thing he'll keep it and not removing it even if it's not used anymore.

---

Suggestion

Maybe we can add a check of if already exist a tox file, if yes we don't render our and just run the tests with the one who is already here