MacOS older version support in wheels #62
Comments
|
Note: In cibuildwheel, regardless of what the current documentation seems to claim, |
|
Thanks for the suggestion, I wasn't aware of that env variable. As a non-mac user I wasn't sure how to control the compat level and the reason for the different wheels on the current version on pypi was ci env differences (azure pipelines vs travis). I agree we should do this as I want to make sure we offer widely compatible wheels for as many platforms as we can for this (the nightly rustc requirement is difficult for some users unfamiliar with the rust ecosystem). I'll push up a pr tomorrow to experiment with setting that env variable in the cibuildwheel environment to see if I can get it to build wheels targeting 10.9. |
In order to maximize compatibility for macOS wheels this commit sets the MACOSX_DEPLOYMENT_TARGET env variable during the wheel building jobs to explicity say we're building with compatibility for MacOS 10.9. Then in order to verify that we're building during CI tests with the same version this commit also updates the macOS test jobs to set the same flag so we do not test with a different build than we publish at release time. Fixes Qiskit#62
|
Ok, I've pushed up a PR (#63) to fix this. I also pushed up test commit to manually trigger the macOS wheel builds to test this. Based on the output of the ci job it looks like it's working: If you want to test the wheels built by the job are hosted here: https://dev.azure.com/qiskit-ci/retworkx/_build/results?buildId=11655&view=artifacts&type=publishedArtifacts (there is a download icon that will appear when you hover your mouse over the drop line, the azure pipelines ui leaves something to be desired) if you want to verify that these work on an older macOS version. Once the PR merges I will soon push out a 0.3.4 release to get the updated wheels on pypi. |
* Revert "Rely on travis for macos wheel builds (#52)" In an effort to get more reliable and compatible MacOS wheel builds at release time this commit switches back to using azure pipelines for the wheel jobs to get a faster and more up to date MacOS image. This commit reverts the switch back to travis which was done to get 10.13 compatible wheels built by using the older MacOS travis env. This is the first step, the next commit will start setting the appropriate compiler flags to set the minimum compat level to an older MacOS version. This reverts commit 8cd11d5. * Explicitly set MACOSX_DEPLOYMENT_TARGET during MacOS jobs In order to maximize compatibility for macOS wheels this commit sets the MACOSX_DEPLOYMENT_TARGET env variable during the wheel building jobs to explicity say we're building with compatibility for MacOS 10.9. Then in order to verify that we're building during CI tests with the same version this commit also updates the macOS test jobs to set the same flag so we do not test with a different build than we publish at release time. Fixes #62 * DNM: Test wheel builds * Revert "DNM: Test wheel builds" This reverts commit 43fb31e.
|
Just wanted to leave a note here, the 0.3.4 release is up on pypi now: https://pypi.org/project/retworkx/0.3.4/#files and the macOS wheels were built with a 10.9 target so local compilation should no longer be required to install the package on older versions of macOS. |
What is the expected enhancement?
I was helping someone install this library and realized that they had macOS 10.12 + Conda Python 3.7, and couldn't pull the wheels since they are 10.13+ (intel) and 10.15+ (normal). Could the
MACOSX_DEPLOYMENT_TARGETbe set to 10.12 or 10.9? I'm guessing it is not set at all, due to the 10.15 in the wheel. If not, is there a reason it can't be lowered?The text was updated successfully, but these errors were encountered: