Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dep versions enlarges final app bundles #55

Closed
antongolub opened this issue Sep 21, 2018 · 1 comment
Closed

Fixed dep versions enlarges final app bundles #55

antongolub opened this issue Sep 21, 2018 · 1 comment

Comments

@antongolub
Copy link
Member

For example, pijma itself requires react@16.4.2, but the app may use 16.5.0, so we get both versions in bundle.

@dimonka83 dimonka83 mentioned this issue Oct 17, 2018
@dimonka83
Copy link
Collaborator

We need make all such dependencies like peerDependencies and get warnings... Or you can simply add resolutions in your project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants