New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad hslString #40

Closed

dy opened this issue Oct 13, 2014 · 2 comments

dy commented Oct 13, 2014

var c = new Color;
c.value(0);

c.hslString() //"hsl(0, NaN%, 0%)"

:(

Author

dy commented Oct 17, 2014

This happens again in color-convert hsv2hsl([0,0,0]), which gives [0, NaN, 0]

Author

dy commented Oct 17, 2014

Fixed: https://github.com/dfcreative/color-convert/commit/5c40d0b72f7daa4324a71f23d888189ed93e2f70.
Qix-/color-convert#12 should do the thing.

harthur closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment