Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme docs for running test are outdated #17

Closed
Qix- opened this issue Jan 19, 2022 · 1 comment · Fixed by #18
Closed

Readme docs for running test are outdated #17

Qix- opened this issue Jan 19, 2022 · 1 comment · Fixed by #18
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Qix-
Copy link
Owner

Qix- commented Jan 19, 2022 •
edited

The readme states you can run tests by running make but this is no longer the case; the library was switched to CMake in order to create a target and to honor the testing flags provided by CMake.

The readme should be updated to reflect this.

mkdir build && cd build
cmake .. -DBUILD_TESTING=ON -DCMAKE_BUILD_TYPE=Debug
cmake --build .
ctest

The above should be tested and, if correct, updated in the readme.
@Qix- Qix- added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jan 19, 2022
@Qix-
Copy link
Owner Author

Qix- commented Jan 19, 2022

Sure! PR welcome :)

@siniarskimar siniarskimar mentioned this issue Feb 1, 2022
Merged
@Qix- Qix- closed this as completed in #18 Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update 'Testing' section in README.md siniarskimar/tortellini
1 participant
@Qix-