Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KPrepublic updating their boards to have a second version #14964

Closed
peepeetee opened this issue Oct 27, 2021 · 6 comments
Closed

KPrepublic updating their boards to have a second version #14964

peepeetee opened this issue Oct 27, 2021 · 6 comments

Comments

@peepeetee
Copy link
Contributor

peepeetee commented Oct 27, 2021

As titled, KPrepublic is updating their boards to have a second version. Should we plan to add a rev1 and a rev2 directory to keyboards that are impacted in this breaking change?

Also, the current naming of KPrepublic boards is a little messy, we could clean that up as well

@peepeetee
Copy link
Contributor Author

@mechmerlin @sigprof

@charlesnchr
Copy link

Hi @peepeetee,

I see you closed this issue, but has a rev2 QMK version actually been added to any of their boards yet?

As you note, the changes to the second version of the board indeed seem to be breaking. I'd be very keen to have a rev2 configuration.

@peepeetee
Copy link
Contributor Author

Hi @peepeetee,

I see you closed this issue, but has a rev2 QMK version actually been added to any of their boards yet?

As you note, the changes to the second version of the board indeed seem to be breaking. I'd be very keen to have a rev2 configuration.

#15177
#15103
#15095
#15060

@peepeetee
Copy link
Contributor Author

Also, for the record, the renaming PR is #15047

@charlesnchr
Copy link

Excellent. Thanks for your hard work 👍

@drashna drashna closed this as completed Dec 24, 2021
@peepeetee
Copy link
Contributor Author

I'd like to reopen this, as #15060 hasn't been merged yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants