Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] wrong definition of digitizer endpoint #23849

Closed
2 tasks
jhorology opened this issue Jun 2, 2024 · 2 comments
Closed
2 tasks

[Bug] wrong definition of digitizer endpoint #23849

jhorology opened this issue Jun 2, 2024 · 2 comments
Assignees

Comments

@jhorology
Copy link

Describe the Bug

#if defined(DIGITIZER_ENABLE) && !defined(DIGITIZER_SHARED_EP)
[USB_ENDPOINT_IN_JOYSTICK] = QMK_USB_ENDPOINT_IN(USB_EP_MODE_TYPE_INTR, DIGITIZER_EPSIZE, DIGITIZER_IN_EPNUM, DIGITIZER_IN_CAPACITY, QMK_USB_REPORT_STORAGE_DEFAULT(sizeof(report_digitizer_t))),
#endif

I think this is a mistake. It should be USB_ENDPOINT_IN_DIGITIZER instead of USB_ENDPOINT_IN_JOYSTICK, shouldn't it?

Keyboard Used

No response

Link to product page (if applicable)

No response

Operating System

No response

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

No response

@jhorology
Copy link
Author

And also 5th parameter of QMK_USB_ENDPOINT_IN() is missing.

@KarlK90
Copy link
Member

KarlK90 commented Jun 2, 2024

@jhorology thanks for reporting this error, I have opened #23854 to fix this.

@KarlK90 KarlK90 closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants