Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some basic functionality for the Compound class #125

Closed
puckvg opened this issue Mar 10, 2020 · 2 comments
Closed

Some basic functionality for the Compound class #125

puckvg opened this issue Mar 10, 2020 · 2 comments

Comments

@puckvg
Copy link

puckvg commented Mar 10, 2020

It's not a bug but rather an enhancement / feature request : when creating mol objects using the Compound class to then generate a Coulomb matrix with mol.generate_coulomb_matrix, we have to specify the desired size of the Coulomb matrix with the size argument. It would be nice if properties such as the number of atoms were available in the Compound class. Currently I'm working around this by reading in the coordinates and atom types from the xyz files myself and generating Coulomb matrices using the representations.generate_coulomb_matrix function instead.

@Dom1L
Copy link

Dom1L commented Mar 19, 2020

You could access the size through the nuclear charges like:

size=compound.nuclear_charges.shape[0]

Hope that helps!

@puckvg
Copy link
Author

puckvg commented Mar 25, 2020

Right, there's just me being an idiot .. thanks!

@puckvg puckvg closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants