-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the parser/compiler usable under Node.js (in a nice way). #41
Comments
Should we add a UMD? Something like github.com/umdjs/umd/blob/master/templates/returnExports.js |
@ChALkeR Yeah, i was getting annoyed at all the globals floating around. @labsin UMD looks good. Are there any implications except the extra code to wrap around? |
@henrikrudstrom Actually, I think we can just use CJS and Browserify/Webpack. I will take a look at this soon. |
Checkout the I've made some exports, but mainly I've cut the access from the external world to most of what was stored in global variables. We should discuss on what gets exported and what doesn't. We might also consider removing some of the gulp concatenation in favor of uses of I can make a PR if you figure what I did in |
The proper way to fix this is described in #173, I think. All those three points are done in qmlweb/qmlweb-parser#6. |
Implemented in qmlweb-parser. |
This means:
Using proper
module.exports
instead of setting globals.Making sure that we don't set globals in the parser.
Making an entrance point that allows users to do something as simple as:
The text was updated successfully, but these errors were encountered: