Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git instructions on wiki page #85

Closed
henrikrudstrom opened this issue Mar 1, 2016 · 3 comments
Closed

git instructions on wiki page #85

henrikrudstrom opened this issue Mar 1, 2016 · 3 comments
Labels

Comments

@henrikrudstrom
Copy link
Member

collected all the git instructions from the comments and created a wiki page; https://github.com/qmlweb/qmlweb/wiki/Contribute-Code

@ChALkeR could you please see if this is correct?

also added some links that describes the general workflow, if anyone has a better/shorter link please suggest it.

Would be good to have a section on when to rebase and when to merge (ff-only or no-ff)
does this make sense to us: http://emmajane.github.io/rebasing-workflow/#/0/26

@ChALkeR
Copy link
Member

ChALkeR commented Mar 2, 2016

Perhaps we should also create a CONTRIBUTING.md file?

@henrikrudstrom
Copy link
Member Author

thats a good idea.

@ChALkeR
Copy link
Member

ChALkeR commented Feb 11, 2018

GitHub "Rebase and merge" is good now, and I decided to remove the complexity with Reviewed-By etc.
Closing for now, will reopen if any issues arise.

@ChALkeR ChALkeR closed this as completed Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants