Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jitescript fails to build with asm-debug-all #15

Closed
ebourg opened this issue Jan 18, 2017 · 3 comments
Closed

jitescript fails to build with asm-debug-all #15

ebourg opened this issue Jan 18, 2017 · 3 comments
Milestone

Comments

@ebourg
Copy link

ebourg commented Jan 18, 2017

Hi,

I noticed that jitescript fails to build if the dependency on asm-all is replaced by asm-debug-all. Here is the error displayed:

src/main/java/me/qmx/jitescript/MethodDefinition.java:[58,36] error: incompatible types: ArrayList<VisibleAnnotation> cannot be converted to List<AnnotationNode>
src/main/java/me/qmx/jitescript/FieldDefinition.java:[25,34] error: incompatible types: ArrayList<VisibleAnnotation> cannot be converted to List<AnnotationNode>

This error doesn't happen with asm-all because the classes are stripped from the debug symbols and the generic signatures.

Maybe VisibleAnnotation should extend AnnotationNode so the list contains the type expected?

@headius
Copy link
Collaborator

headius commented May 20, 2021

That would make sense. I can try to fix it later but if you can PR a fix that would be helpful!

@tkoeppe
Copy link
Contributor

tkoeppe commented May 20, 2021

I believe I have a fix for this, too, as we too found this. Would you like it?

@tkoeppe
Copy link
Contributor

tkoeppe commented May 20, 2021

That's #20.

@headius headius added this to the 0.4.3 milestone May 20, 2021
@headius headius closed this as completed May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants